Skip to content

tests: allow to expect reaching one or multiple Cluster phases - #2858

Merged
sxd merged 2 commits into
mainfrom
dev/2857
Sep 26, 2023
Merged

tests: allow to expect reaching one or multiple Cluster phases#2858
sxd merged 2 commits into
mainfrom
dev/2857

Conversation

@litaocdl

@litaocdl litaocdl commented Sep 25, 2023 •
edited by NiccoloFei
Loading

Copy link
Copy Markdown
Collaborator

Closes #2857

@litaocdl

litaocdl commented Sep 25, 2023

Copy link
Copy Markdown
Collaborator Author

/test limit=local

@github-actions github-actions Bot added backport-requested ◀️ This pull request should be backported to all supported releases release-1.19 labels Sep 25, 2023
@github-actions

github-actions Bot commented Sep 25, 2023

Copy link
Copy Markdown
Contributor

❗ By default, the pull request is configured to backport to all release branches.

  • To stop backporting this pr, remove the label: backport-requested ◀️ or add the label 'do not backport'
  • To stop backporting this pr to a certain release branch, remove the specific branch label: release-x.y

@github-actions

github-actions Bot commented Sep 25, 2023

Copy link
Copy Markdown
Contributor

@litaocdl, here's the link to the E2E on CNPG workflow run: https://github.com/cloudnative-pg/cloudnative-pg/actions/runs/6296239281

@NiccoloFei

NiccoloFei commented Sep 25, 2023

Copy link
Copy Markdown
Collaborator

/test feature_type=backup-restore

@github-actions

github-actions Bot commented Sep 25, 2023

Copy link
Copy Markdown
Contributor

@NiccoloFei, here's the link to the E2E on CNPG workflow run: https://github.com/cloudnative-pg/cloudnative-pg/actions/runs/6298252998

@github-actions github-actions Bot added the ok to merge 👌 This PR can be merged label Sep 25, 2023
@NiccoloFei
NiccoloFei force-pushed the dev/2857 branch 2 times, most recently from ad08b86 to a49d879 Compare September 25, 2023 16:33
@NiccoloFei NiccoloFei changed the title fix: fix separate pg_wal volume e2e test case tests: avoid expecting to reach phases which are quickly replaced Sep 25, 2023
@NiccoloFei

NiccoloFei commented Sep 25, 2023

Copy link
Copy Markdown
Collaborator

/test

@github-actions

github-actions Bot commented Sep 25, 2023

Copy link
Copy Markdown
Contributor

@NiccoloFei, here's the link to the E2E on CNPG workflow run: https://github.com/cloudnative-pg/cloudnative-pg/actions/runs/6302235120

@NiccoloFei
NiccoloFei force-pushed the dev/2857 branch 2 times, most recently from 5ab5634 to f555cc0 Compare September 26, 2023 11:22
@NiccoloFei

NiccoloFei commented Sep 26, 2023

Copy link
Copy Markdown
Collaborator

/test feature_type=backup-restore,replication

@github-actions

github-actions Bot commented Sep 26, 2023

Copy link
Copy Markdown
Contributor

@NiccoloFei, here's the link to the E2E on CNPG workflow run: https://github.com/cloudnative-pg/cloudnative-pg/actions/runs/6312117962

@NiccoloFei NiccoloFei changed the title tests: avoid expecting to reach phases which are quickly replaced tests: allow to expect reaching for multiple Cluster phases Sep 26, 2023
@NiccoloFei NiccoloFei changed the title tests: allow to expect reaching for multiple Cluster phases tests: allow to expect reaching one or multiple Cluster phases Sep 26, 2023
@NiccoloFei @sxd
tests: avoid expecting to reach phases which are quickly replaced
ff67839 
Since the introduction of phaseWaitingForInstancesToBeActive, PhaseUpgrade/PhaseFailOver
(and other phases) are now properly being replaced by the newly introduced phase right after
the related operation is complete. Because these phases get superseded very quickly, we should
not rely passing through them during the E2E tests.

Signed-off-by: Niccolò Fei <[email protected]>
@NiccoloFei @sxd
chore: fix typos
a138e5d 
Signed-off-by: Niccolò Fei <[email protected]>
@sxd
sxd merged commit 451c581 into main Sep 26, 2023
@sxd
sxd deleted the dev/2857 branch September 26, 2023 14:16
cnpg-bot pushed a commit that referenced this pull request Sep 26, 2023
@litaocdl @NiccoloFei
tests: allow to expect reaching one or multiple Cluster phases (#2858)
6afa4f5 
Since the introduction of phaseWaitingForInstancesToBeActive, PhaseUpgrade/PhaseFailOver
(and other phases) are now properly being replaced by the newly introduced phase right after
the related operation is complete. Because these phases get superseded very quickly, we should
not rely passing through them during the E2E tests.

Signed-off-by: Niccolò Fei <[email protected]>
Co-authored-by: Niccolò Fei <[email protected]>
(cherry picked from commit 451c581)
cnpg-bot pushed a commit that referenced this pull request Sep 26, 2023
@litaocdl @NiccoloFei
tests: allow to expect reaching one or multiple Cluster phases (#2858)
08e0533 
Since the introduction of phaseWaitingForInstancesToBeActive, PhaseUpgrade/PhaseFailOver
(and other phases) are now properly being replaced by the newly introduced phase right after
the related operation is complete. Because these phases get superseded very quickly, we should
not rely passing through them during the E2E tests.

Signed-off-by: Niccolò Fei <[email protected]>
Co-authored-by: Niccolò Fei <[email protected]>
(cherry picked from commit 451c581)
Lennart01 pushed a commit to Lennart01/cloudnative-pg that referenced this pull request Sep 30, 2023
@litaocdl @NiccoloFei @Lennart01
tests: allow to expect reaching one or multiple Cluster phases (cloud…
4337569 
…native-pg#2858)

Since the introduction of phaseWaitingForInstancesToBeActive, PhaseUpgrade/PhaseFailOver
(and other phases) are now properly being replaced by the newly introduced phase right after
the related operation is complete. Because these phases get superseded very quickly, we should
not rely passing through them during the E2E tests.

Signed-off-by: Niccolò Fei <[email protected]>
Co-authored-by: Niccolò Fei <[email protected]>
Signed-off-by: Lennart Krauch <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@NiccoloFei NiccoloFei NiccoloFei approved these changes
@fcanovai fcanovai Awaiting requested review from fcanovai
@gbartolini gbartolini Awaiting requested review from gbartolini
@leonardoce leonardoce Awaiting requested review from leonardoce
@mnencia mnencia Awaiting requested review from mnencia
@phisco phisco Awaiting requested review from phisco
@armru armru Awaiting requested review from armru
+2 more reviewers
@jsilvela jsilvela jsilvela approved these changes
@sxd sxd sxd approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

backport-requested ◀️ This pull request should be backported to all supported releases ok to merge 👌 This PR can be merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

e2e separate pg_wal volume is failing

4 participants

@litaocdl @NiccoloFei @jsilvela @sxd