Skip to content

feat: avoid fencing instance unnecessarily in volume snapshots - #2854

Merged
mnencia merged 5 commits into
mainfrom
dev/2853
Sep 27, 2023
Merged

mnencia merged 5 commits into
mainfrom
dev/2853

Conversation

@jsilvela

Copy link
Copy Markdown
Contributor

Closes #2853

@github-actions github-actions Bot added backport-requested ◀️ This pull request should be backported to all supported releases release-1.19 labels Sep 23, 2023
@github-actions

Copy link
Copy Markdown
Contributor

❗ By default, the pull request is configured to backport to all release branches.

  • To stop backporting this pr, remove the label: backport-requested ◀️ or add the label 'do not backport'
  • To stop backporting this pr to a certain release branch, remove the specific branch label: release-x.y

@jsilvela

Copy link
Copy Markdown
Contributor Author

/test

@github-actions

Copy link
Copy Markdown
Contributor

@jsilvela jsilvela added do not backport This PR must not be backported - it will be in the next minor release and removed backport-requested ◀️ This pull request should be backported to all supported releases release-1.19 labels Sep 23, 2023
@mnencia
mnencia force-pushed the dev/2853 branch 3 times, most recently from a187354 to 30d434e Compare September 26, 2023 17:07
@mnencia

mnencia commented Sep 27, 2023

Copy link
Copy Markdown
Member

@cnpg-bot cnpg-bot added the ok to merge 👌 This PR can be merged label Sep 27, 2023
@mnencia
mnencia merged commit bd39be6 into main Sep 27, 2023
@mnencia
mnencia deleted the dev/2853 branch September 27, 2023 08:07
Lennart01 pushed a commit to Lennart01/cloudnative-pg that referenced this pull request Sep 30, 2023
…native-pg#2854)

Previously, the volume snapshot code could fence a node
multiple times, leading to handling errors.
The new implementation fences nodes only when necessary.

Closes cloudnative-pg#2853

Signed-off-by: Jaime Silvela <[email protected]>
Signed-off-by: Armando Ruocco <[email protected]>
Co-authored-by: Armando Ruocco <[email protected]>
Signed-off-by: Lennart Krauch <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do not backport This PR must not be backported - it will be in the next minor release ok to merge 👌 This PR can be merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Volume snapshot reconciler should fence instances only if there are no snapshots

5 participants