Repository navigation
chore: always push a new image after merging on main - #2850
Merged
Merged
Conversation
NiccoloFei
requested review from
armru,
fcanovai,
gbartolini,
leonardoce,
mnencia,
phisco and
sxd
as code owners
September 22, 2023 13:50
github-actions
Bot
added
backport-requested ◀️
Contributor
|
❗ By default, the pull request is configured to backport to all release branches.
|
gbartolini
approved these changes
Sep 22, 2023
Signed-off-by: Niccolò Fei <[email protected]>
Signed-off-by: Gabriele Bartolini <[email protected]>
sxd
force-pushed
the
dev/fix-image-always-push
branch
from
September 27, 2023 01:15
ca0cc68 to
400fa0e
Compare
sxd
approved these changes
Sep 27, 2023
Contributor
|
/ok-to-merge CI |
cnpg-bot
pushed a commit
that referenced
this pull request
Sep 27, 2023
The continuous-integration was only actually pushing images when a PR was labeled with "always push images", but we should also produce the images whenever a new commit is pushed on main or a release branch. This will ensure that the `ghcr.io/cloudnative-pg/cloudnative-pg-testing` main and release-* images are updated as soon as a new commit is pushed (up until now it was done only once per day via the continuous-delivery workflow) Signed-off-by: Niccolò Fei <[email protected]> Signed-off-by: Gabriele Bartolini <[email protected]> Co-authored-by: Gabriele Bartolini <[email protected]> (cherry picked from commit ab0d5bc)
cnpg-bot
pushed a commit
that referenced
this pull request
Sep 27, 2023
The continuous-integration was only actually pushing images when a PR was labeled with "always push images", but we should also produce the images whenever a new commit is pushed on main or a release branch. This will ensure that the `ghcr.io/cloudnative-pg/cloudnative-pg-testing` main and release-* images are updated as soon as a new commit is pushed (up until now it was done only once per day via the continuous-delivery workflow) Signed-off-by: Niccolò Fei <[email protected]> Signed-off-by: Gabriele Bartolini <[email protected]> Co-authored-by: Gabriele Bartolini <[email protected]> (cherry picked from commit ab0d5bc)
Lennart01
pushed a commit
to Lennart01/cloudnative-pg
that referenced
this pull request
Sep 30, 2023
…2850) The continuous-integration was only actually pushing images when a PR was labeled with "always push images", but we should also produce the images whenever a new commit is pushed on main or a release branch. This will ensure that the `ghcr.io/cloudnative-pg/cloudnative-pg-testing` main and release-* images are updated as soon as a new commit is pushed (up until now it was done only once per day via the continuous-delivery workflow) Signed-off-by: Niccolò Fei <[email protected]> Signed-off-by: Gabriele Bartolini <[email protected]> Co-authored-by: Gabriele Bartolini <[email protected]> Signed-off-by: Lennart Krauch <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The continuous-integration was only actually pushing images when a PR was labeled with "always push images".
But we should also produce the images whenever a new commit is pushed on main or a release branch.
This will ensure that the
ghcr.io/cloudnative-pg/cloudnative-pg-testingmain and release-* images are updated as soon as a new commit is pushed (up until now it was done only once per day via the continuos-delivery workflow)