Skip to content

feat!: change default value of switchoverDelay to 3600 - #2846

Merged
gbartolini merged 2 commits into
mainfrom
dev/2845
Sep 22, 2023
Merged

feat!: change default value of switchoverDelay to 3600#2846
gbartolini merged 2 commits into
mainfrom
dev/2845

Conversation

@gbartolini

@gbartolini gbartolini commented Sep 21, 2023 •
edited by armru
Loading

Copy link
Copy Markdown
Contributor

BREAKING CHANGE: The default value of switchoverDelay has now been changed to 3600 seconds, equivalent of 1 hour. Previously, it was set to 40000000 seconds.

Closes #2845

@gbartolini gbartolini added do not backport This PR must not be backported - it will be in the next minor release enhancement 🪄 New feature or request labels Sep 21, 2023
@gbartolini gbartolini added this to the 1.21.0 milestone Sep 21, 2023
@gbartolini gbartolini added backport-requested ◀️ This pull request should be backported to all supported releases release-1.19 and removed do not backport This PR must not be backported - it will be in the next minor release labels Sep 21, 2023
@github-actions

github-actions Bot commented Sep 21, 2023

Copy link
Copy Markdown
Contributor

❗ By default, the pull request is configured to backport to all release branches.

  • To stop backporting this pr, remove the label: backport-requested ◀️ or add the label 'do not backport'
  • To stop backporting this pr to a certain release branch, remove the specific branch label: release-x.y

@github-actions

github-actions Bot commented Sep 21, 2023

Copy link
Copy Markdown
Contributor

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

6 similar comments
@github-actions

github-actions Bot commented Sep 21, 2023

Copy link
Copy Markdown
Contributor

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@github-actions

github-actions Bot commented Sep 21, 2023

Copy link
Copy Markdown
Contributor

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@github-actions

github-actions Bot commented Sep 21, 2023

Copy link
Copy Markdown
Contributor

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@github-actions

github-actions Bot commented Sep 21, 2023

Copy link
Copy Markdown
Contributor

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@github-actions

github-actions Bot commented Sep 21, 2023

Copy link
Copy Markdown
Contributor

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@github-actions

github-actions Bot commented Sep 21, 2023

Copy link
Copy Markdown
Contributor

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@armru

armru commented Sep 21, 2023

Copy link
Copy Markdown
Member

/test limit=local

@github-actions

github-actions Bot commented Sep 21, 2023

Copy link
Copy Markdown
Contributor

@armru, here's the link to the E2E on CNPG workflow run: https://github.com/cloudnative-pg/cloudnative-pg/actions/runs/6265267709

@armru

armru commented Sep 22, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

The default value only affects new clusters; is this a breaking change?
The current clusters maintain the current behaviour, I do agree that we should make highlight the change in the patch notes

gbartolini and others added 2 commits September 22, 2023 12:29
@gbartolini
feat!: change default value of switchoverDelay to 3600
f72f7c3 
BREAKING CHANGE: The default value of `switchoverDelay` has now
been changed to 3600 seconds, equivalent of 1 hour.
Previously, it was set to 40000000 seconds.

Closes #2845

Signed-off-by: Gabriele Bartolini <[email protected]>
@litaocdl @gbartolini
review: also change the constants and doc
0ebf50e 
Signed-off-by: Tao Li <[email protected]>
@gbartolini
gbartolini merged commit 9565f9f into main Sep 22, 2023
@gbartolini
gbartolini deleted the dev/2845 branch September 22, 2023 10:31
cnpg-bot pushed a commit that referenced this pull request Sep 22, 2023
@gbartolini @litaocdl
feat: change default value of switchoverDelay to 3600 (#2846)
4cc1c78 
IMPORTANT: The default value of `switchoverDelay` has now been
changed to 3600 seconds, equivalent of 1 hour.

Previously, it was set to 40000000 seconds.

Closes #2845

Signed-off-by: Gabriele Bartolini <[email protected]>
Signed-off-by: Tao Li <[email protected]>
Co-authored-by: Tao Li <[email protected]>
(cherry picked from commit 9565f9f)
cnpg-bot pushed a commit that referenced this pull request Sep 22, 2023
@gbartolini @litaocdl
feat: change default value of switchoverDelay to 3600 (#2846)
5e2f36f 
IMPORTANT: The default value of `switchoverDelay` has now been
changed to 3600 seconds, equivalent of 1 hour.

Previously, it was set to 40000000 seconds.

Closes #2845

Signed-off-by: Gabriele Bartolini <[email protected]>
Signed-off-by: Tao Li <[email protected]>
Co-authored-by: Tao Li <[email protected]>
(cherry picked from commit 9565f9f)
@gbartolini gbartolini mentioned this pull request Oct 23, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@leonardoce leonardoce leonardoce approved these changes
@litaocdl litaocdl litaocdl approved these changes
@fcanovai fcanovai Awaiting requested review from fcanovai
@mnencia mnencia Awaiting requested review from mnencia
@phisco phisco Awaiting requested review from phisco
@sxd sxd Awaiting requested review from sxd
@armru armru Awaiting requested review from armru

Assignees

No one assigned

Labels

backport-requested ◀️ This pull request should be backported to all supported releases enhancement 🪄 New feature or request

Projects

CloudNativePG operator development
Status: Done

Milestone

1.21.0

Development

Successfully merging this pull request may close these issues.

Set switchoverDelay to 3600

4 participants

@gbartolini @armru @leonardoce @litaocdl