Skip to content

feat: bring backup status of snapshots to parity with barman - #2838

Merged
mnencia merged 12 commits into
mainfrom
dev/2813
Sep 26, 2023
Merged

feat: bring backup status of snapshots to parity with barman#2838
mnencia merged 12 commits into
mainfrom
dev/2813

Conversation

@jsilvela

@jsilvela jsilvela commented Sep 21, 2023

Copy link
Copy Markdown
Contributor

Closes #2813

@github-actions github-actions Bot added backport-requested ◀️ This pull request should be backported to all supported releases release-1.19 labels Sep 21, 2023
@github-actions

github-actions Bot commented Sep 21, 2023

Copy link
Copy Markdown
Contributor

❗ By default, the pull request is configured to backport to all release branches.

  • To stop backporting this pr, remove the label: backport-requested ◀️ or add the label 'do not backport'
  • To stop backporting this pr to a certain release branch, remove the specific branch label: release-x.y

@jsilvela
jsilvela changed the base branch from main to dev/wip-backup-status September 21, 2023 13:24
@jsilvela
jsilvela changed the base branch from dev/wip-backup-status to main September 21, 2023 13:57
@jsilvela
jsilvela changed the base branch from main to dev/wip-backup-status September 21, 2023 13:57
@jsilvela
jsilvela force-pushed the dev/2813 branch 2 times, most recently from 57b7c77 to 487f9bf Compare September 21, 2023 14:26
@NiccoloFei
NiccoloFei force-pushed the dev/wip-backup-status branch from 38dcc2d to 0cf703f Compare September 22, 2023 09:28
@gbartolini
gbartolini force-pushed the dev/wip-backup-status branch from 0cf703f to 151caff Compare September 22, 2023 10:21
Base automatically changed from dev/wip-backup-status to main September 22, 2023 10:25
@jsilvela jsilvela added do not backport This PR must not be backported - it will be in the next minor release and removed backport-requested ◀️ This pull request should be backported to all supported releases release-1.19 labels Sep 23, 2023
@armru
armru force-pushed the dev/2813 branch 2 times, most recently from 14bb433 to 775eb74 Compare September 25, 2023 08:28
@armru

armru commented Sep 25, 2023

Copy link
Copy Markdown
Member

/test limit=local

1 similar comment
@armru

armru commented Sep 25, 2023

Copy link
Copy Markdown
Member

/test limit=local

@github-actions

github-actions Bot commented Sep 25, 2023

Copy link
Copy Markdown
Contributor

@armru, here's the link to the E2E on CNPG workflow run: https://github.com/cloudnative-pg/cloudnative-pg/actions/runs/6296838056

@armru

armru commented Sep 25, 2023

Copy link
Copy Markdown
Member

/test limit=local

@github-actions

github-actions Bot commented Sep 25, 2023

Copy link
Copy Markdown
Contributor

@armru, here's the link to the E2E on CNPG workflow run: https://github.com/cloudnative-pg/cloudnative-pg/actions/runs/6298996118

@gbartolini gbartolini added the always push images This PR will continuously push a container image every time a new commit is pushed label Sep 25, 2023
@mnencia

mnencia commented Sep 25, 2023

Copy link
Copy Markdown
Member

/test

@github-actions

github-actions Bot commented Sep 25, 2023

Copy link
Copy Markdown
Contributor

@mnencia, here's the link to the E2E on CNPG workflow run: https://github.com/cloudnative-pg/cloudnative-pg/actions/runs/6300908856

@mnencia
mnencia force-pushed the dev/2813 branch 2 times, most recently from b308133 to ff4d3d3 Compare September 26, 2023 13:13
@mnencia

mnencia commented Sep 26, 2023

Copy link
Copy Markdown
Member

/test

@github-actions

github-actions Bot commented Sep 26, 2023

Copy link
Copy Markdown
Contributor

@mnencia, here's the link to the E2E on CNPG workflow run: https://github.com/cloudnative-pg/cloudnative-pg/actions/runs/6313511022

@mnencia

mnencia commented Sep 26, 2023

Copy link
Copy Markdown
Member

/ok-to-merge E2E tests green on EDB fork https://github.com/EnterpriseDB/cloudnative-pg/actions/runs/6313760209/job/17142807170

@cnpg-bot cnpg-bot added the ok to merge 👌 This PR can be merged label Sep 26, 2023
jsilvela and others added 12 commits September 26, 2023 18:43
@jsilvela @mnencia
feat: bring backup status of snapshots to parity with barman
f00a818 
Signed-off-by: Jaime Silvela <[email protected]>
@jsilvela @mnencia
fix: lint
0089840 
Signed-off-by: Jaime Silvela <[email protected]>
@jsilvela @mnencia
fix: parse controldata, de-bounce unfencing
2ef08de 
Signed-off-by: Jaime Silvela <[email protected]>
@jsilvela @mnencia
review: clean up
4bd3f7d 
Signed-off-by: Jaime Silvela <[email protected]>
@jsilvela @mnencia
review: get the right fields of pg_controldata
2ab67a3 
Signed-off-by: Jaime Silvela <[email protected]>
@armru @mnencia
chore: linter error
31f9571 
Signed-off-by: Armando Ruocco <[email protected]>
@armru @mnencia
test: integrate e2e tests
a0ea6bd 
Signed-off-by: Armando Ruocco <[email protected]>
@armru @mnencia
chore: reorder methods
d2c9664 
Signed-off-by: Armando Ruocco <[email protected]>
@armru @mnencia
refactor: adapt existing code
e93da9a 
Signed-off-by: Armando Ruocco <[email protected]>
@mnencia
chore: unify ensurePodIsFenced and EnsurePodIsUnfenced structure
f33d7f1 
Signed-off-by: Marco Nenciarini <[email protected]>
@mnencia
fix: output is on stdout
f87dea4 
Signed-off-by: Marco Nenciarini <[email protected]>
@mnencia
fix: match pg_controldata output line key
f3032f3 
Signed-off-by: Marco Nenciarini <[email protected]>
@mnencia
mnencia merged commit ed0b873 into main Sep 26, 2023
@mnencia
mnencia deleted the dev/2813 branch September 26, 2023 17:07
Lennart01 pushed a commit to Lennart01/cloudnative-pg that referenced this pull request Sep 30, 2023
@jsilvela @armru
@mnencia @Lennart01
feat: enrich the Backup status with volume snapshots (cloudnative-pg#…
46e4423 
…2838)

This patch enhances the status section of a volume snapshot Backup
with Postgres metadata to match the status of an object store backup.

Closes cloudnative-pg#2813

Signed-off-by: Jaime Silvela <[email protected]>
Signed-off-by: Armando Ruocco <[email protected]>
Signed-off-by: Marco Nenciarini <[email protected]>
Co-authored-by: Armando Ruocco <[email protected]>
Co-authored-by: Marco Nenciarini <[email protected]>
Signed-off-by: Lennart Krauch <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mnencia mnencia mnencia approved these changes
@armru armru armru approved these changes
@fcanovai fcanovai Awaiting requested review from fcanovai
@gbartolini gbartolini Awaiting requested review from gbartolini
@leonardoce leonardoce Awaiting requested review from leonardoce
@phisco phisco Awaiting requested review from phisco
@sxd sxd Awaiting requested review from sxd

Assignees

No one assigned

Labels

always push images This PR will continuously push a container image every time a new commit is pushed do not backport This PR must not be backported - it will be in the next minor release ok to merge 👌 This PR can be merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Enrich the Backup status with volume snapshots

5 participants

@jsilvela @armru @mnencia @gbartolini @cnpg-bot