Repository navigation
fix: use correct endpointURL in Linode example (#2629) - #2630
Conversation
github-actions
Bot
added
backport-requested ◀️
|
❗ By default, the pull request is configured to backport to all release branches.
|
f88b939 to
71410e9
Compare
|
I don't see a reason to change this, since when you are asked for the endpoint your are asking for the bucket endpoint, what linode is allowing here, it's a nice feature, but it's common to point to the bucket and then a path inside the bucket, this allow users to have the same endpoint but a different path if they want different directories inside the same bucket. Why you think this is needed ? Regards! |
|
@sxd I wanted to change this because the bucket name should not be included in the endpoint URL. According to Linode:
The docs currently suggest using the bucket URL for the endpoint URL - if a user does this then they will end up with a configuration which works for some requests and does not for others. This is the case when using either barman cloud or the AWS cli to interact with the bucket. Debugging the resulting behaviour is time consuming, as demonstrated in both #1313 and EnterpriseDB/barman#835. So the line I really care about changing here is: because it suggests to users they should include the bucket name in the endpoint, which is not going to end well. Keeping an example path in the |
Updates the endpointURL for the Linode example in object_stores.md so
that it does not include the bucket name and moves the bucket name into
the S3 URL provided to destinationPath.
This is based on the recommendations in the current Linode documentation
at:
https://www.linode.com/docs/products/storage/object-storage/guides/urls/#cluster-url-s3-endpoint
Closes cloudnative-pg#2629
Signed-off-by: Michael Wallace <[email protected]>
Updates the endpointURL for the Linode example in object_stores.md so that it does not include the bucket name and moves the bucket name into the S3 URL provided to destinationPath. This is based on the recommendations in the current Linode documentation at: https://www.linode.com/docs/products/storage/object-storage/guides/urls/#cluster-url-s3-endpoint Closes #2629 Signed-off-by: Michael Wallace <[email protected]> (cherry picked from commit db3a057)
Updates the endpointURL for the Linode example in object_stores.md so that it does not include the bucket name and moves the bucket name into the S3 URL provided to destinationPath. This is based on the recommendations in the current Linode documentation at: https://www.linode.com/docs/products/storage/object-storage/guides/urls/#cluster-url-s3-endpoint Closes #2629 Signed-off-by: Michael Wallace <[email protected]>
…loudnative-pg#2630) Updates the endpointURL for the Linode example in object_stores.md so that it does not include the bucket name and moves the bucket name into the S3 URL provided to destinationPath. This is based on the recommendations in the current Linode documentation at: https://www.linode.com/docs/products/storage/object-storage/guides/urls/#cluster-url-s3-endpoint Closes cloudnative-pg#2629 Signed-off-by: Michael Wallace <[email protected]> Signed-off-by: Lennart Krauch <[email protected]>
Updates the endpointURL for the Linode example in object_stores.md so that it does not include the bucket name and moves the bucket name into the S3 URL provided to destinationPath.
This is based on the recommendations in the current Linode documentation at:
Closes #2629