You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Bug]: Backups field indexer used by ScheduledBackup controller always returns empty #9485
The indexer used by the ScheduledBackup controller to find child Backups doesn't work because it checks Backups for owner references of kind Backup instead of ScheduledBackup:
This check means that the indexer never returns any results and so the GetChildBackups method always returns an empty slice.
Even if it correctly looked for owners of kind ScheduledBackup, it would only work for the cases where the ScheduledBackup is configured with:
backupOwnerReference: self
When backupOwnerReference is set to none (the default) or cluster this indexer will also not return anything.
The intended purpose of the GetChildBackups method that uses the indexer is to prevent concurrent Backups for a ScheduledBackup. The check has never worked and the Backup controller handles concurrency itself by checking for running Backups before starting a new one.
Activity
andrew-farries commentedon Dec 17, 2025
PR to remove the indexer is here: #9466
armru commentedon Dec 18, 2025
I think we could fix the bug with a minimal approach: #9489
fix(scheduledbackup): use label-based indexer instead of ownership (#…
fix(scheduledbackup): use label-based indexer instead of ownership (#…
fix(scheduledbackup): use label-based indexer instead of ownership (#…
fix(scheduledbackup): use label-based indexer instead of ownership (c…
fix(scheduledbackup): use label-based indexer instead of ownership (#…