You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Volume snapshot reconciler should fence instances only if there are no snapshots #2853
The volumesnapshot reconciler starts by fencing the target pod right away.
This can lead to trouble if the top reconciliation loop has an error downstream that prevents a backup from being marked as completed.
In such case, the backup reconciler will get called once again, and will start by fencing the instance, then doing a listing where it might well detect that there are voluesnapshots already created, and would then proceed to unfence the instance.
We should only be fencing the pod if we have positively identified that there are no volumesnapshots created.
The logic of the snapshot backup reconciler is:
Step 1: fencing
Step 2: create snapshots
Step 3: wait for snapshots to be ready
as implemented in the volumesnapshot reconciler code (pkg/reconciler/backup/volumesnapshot/resources.go):
// Execute the volume snapshot of the given cluster instancefunc (se*Reconciler) Execute(
Activity
feat: avoid fencing instance unnecessarily in volume snapshots (#2854)
feat: avoid fencing instance unnecessarily in volume snapshots (cloud…