Skip to content

Enrich the Backup status with volume snapshots #2813

Closed

Description

@gbartolini

At the moment, the status of a Backup resource is not coherent between the object store case and the volume snapshot one. For example, this is a backup taken with object stores:

Status:
  Backup Id:         20230918T213041
  Backup Name:       backup-1695072640
  Begin LSN:         1C/B4000028
  Begin Wal:         000000010000001C0000002D
  Destination Path:  s3://angus/
  End LSN:           1C/C0000000
  End Wal:           000000010000001C00000030
  Instance ID:
    Container ID:  containerd://49914699b198326195252adbc0d1b46c8b8b156c7021f5cd2ad573c02c4cb8e1
    Pod Name:      angus-2
  Method:          barmanObjectStore
  Phase:           completed
  s3Credentials:
    Inherit From IAM Role:  true
  Server Name:              angus
  Started At:               2023-09-18T21:30:41Z
  Stopped At:               2023-09-18T22:36:29Z

On the other hand, this is the status of a volume snapshot backup:

Status:
  Backup Id:  angus-backup-02
  Instance ID:
    Container ID:  containerd://49914699b198326195252adbc0d1b46c8b8b156c7021f5cd2ad573c02c4cb8e1
    Pod Name:      angus-2
  Method:          volumeSnapshot
  Phase:           completed
  Snapshot Backup Status:
    Snapshots:
      angus-2-1695047917
      angus-2-wal-1695047917 

As you can see, relevant information is missing, in particular:

  • Started At
  • Stopped At
  • Begin LSN
  • Begin WAL
  • End LSN
  • End WAL

Check also the discrepancy when treating the Id and Name of the backup in the two methods.

The information here MUST be coherent with the one included as labels and annotations in the volume snapshots (#2794).

Activity

  1. added this to the 1.21.0 milestone on Sep 19, 2023
  2. added
    always push imagesThis PR will continuously push a container image every time a new commit is pushed
    do not backportThis PR must not be backported - it will be in the next minor release
    on Sep 25, 2023
  3. added a commit that references this issue on Sep 26, 2023
    ed0b873
  4. added a commit that references this issue on Sep 30, 2023
    46e4423
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    always push imagesThis PR will continuously push a container image every time a new commit is pusheddo not backportThis PR must not be backported - it will be in the next minor releaseenhancement 🪄New feature or request

    Type

    No type

    Projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions