Repository navigation
[Bug]: external cluster plugin with enabled: false is still treated as active #10930
Description
Is there an existing issue already for this bug?
- I have searched for an existing issue, and could not find anything. I believe this is a new bug.
I have read the troubleshooting guide
- I have read the troubleshooting guide and I think this is a new bug.
I am running a supported version of CloudNativePG
- I have read the troubleshooting guide and I think this is a new bug.
Version
trunk (main)
What happened?
Setting enabled: false on an external cluster's plugin configuration is not honoured: the plugin is still treated as active. The spec.plugins path handles this correctly via IsEnabled(), but the equivalent function for external cluster plugins does not.
The bug was introduced in #6426 and surfaced by #10836.
Relevant log output
No specific log output.
Code of Conduct
- I agree to follow this project's Code of Conduct
Reacted by dosubot
Activity
[-][Bug]: GetExternalClustersEnabledPluginNames ignores the Enabled flag on external cluster plugins[/-][+][Bug]: external cluster plugin with enabled: false is still treated as active[/+]fix(plugins): honour enabled flag on external cluster plugin configur…
fix(plugins): honour enabled flag on external cluster plugin configur…
fix(plugins): honour enabled flag on external cluster plugin configur…
fix(plugins): honour enabled flag on external cluster plugin configur…
fix(plugins): honour enabled flag on external cluster plugin configur…