Skip to content

Commit e7d6db3

Browse files
authored
fix(lint): work around nolintlint false positives from cache bug (#10136)
Set allow-unused: true for nolintlint to prevent flaky CI failures caused by a known golangci-lint bug (golangci/golangci-lint#3228) where the internal cache loses staticcheck SA1019 deprecation facts across runs, causing nolintlint to falsely report `//nolint:staticcheck` directives as unused. Signed-off-by: Marco Nenciarini <[email protected]>
1 parent 407bade commit e7d6db3

1 file changed

Lines changed: 5 additions & 0 deletions

File tree

‎.golangci.yml‎

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -87,6 +87,11 @@ linters:
8787
alias: metav1
8888
- pkg: k8s.io/client-go/kubernetes/typed/core/v1
8989
alias: corev1client
90+
nolintlint:
91+
# We are temporarily allowing unused nolints due to apparently
92+
# false failures in CI. See
93+
# https://github.com/golangci/golangci-lint/issues/3228
94+
allow-unused: true
9095
exclusions:
9196
generated: lax
9297
rules:

0 commit comments

Comments
 (0)