Skip to content

Commit aa2b911

Browse files
mnenciaarmru
andauthored
fix: properly return errors when removing Database finalizers (#9431)
Closes #9430 Signed-off-by: Marco Nenciarini <[email protected]> Signed-off-by: Armando Ruocco <[email protected]> Co-authored-by: Armando Ruocco <[email protected]>
1 parent 2abbb31 commit aa2b911

1 file changed

Lines changed: 3 additions & 1 deletion

File tree

‎internal/controller/cluster_controller.go‎

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -170,6 +170,7 @@ func (r *ClusterReconciler) Reconcile(ctx context.Context, req ctrl.Request) (ct
170170
"configMapName", apiv1.DefaultMonitoringConfigMapName,
171171
"namespace", req.Namespace,
172172
)
173+
return ctrl.Result{}, err
173174
}
174175
if err := r.notifyDeletionToOwnedResources(ctx, req.NamespacedName); err != nil {
175176
contextLogger.Error(
@@ -178,8 +179,9 @@ func (r *ClusterReconciler) Reconcile(ctx context.Context, req ctrl.Request) (ct
178179
"clusterName", req.Name,
179180
"namespace", req.Namespace,
180181
)
182+
return ctrl.Result{}, err
181183
}
182-
return ctrl.Result{}, err
184+
return ctrl.Result{}, nil
183185
}
184186

185187
ctx = cluster.SetInContext(ctx)

0 commit comments

Comments
 (0)