Repository navigation
Commit 1c9d44e
fix(pvc-resize): avoid deadlock on simultaneous storage and resource change
When both storage.size and resources are changed in a single PATCH,
the operator resizes PVCs and then immediately starts a rolling
update that deletes a pod. The orphaned PVC was classified as
"resizing" instead of "dangling", preventing the pod from being
recreated and leaving the cluster stuck.
Fix by always classifying podless resizing PVCs as "dangling" so a
replacement pod is created. This is safe because volumes are usable
during expansion and filesystem resize requires a mounted pod anyway.
Also remove the now-unused isFileSystemResizePending helper, which
was only called from the removed conditional branch in classifyPVC.
Closes #9786
Signed-off-by: Marco Nenciarini <[email protected]>1 parent fa5635c commit 1c9d44e
3 files changed
Lines changed: 33 additions & 53 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
79 | 79 | | |
80 | 80 | | |
81 | 81 | | |
82 | | - | |
83 | | - | |
84 | | - | |
85 | | - | |
86 | 82 | | |
87 | 83 | | |
88 | 84 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
109 | 109 | | |
110 | 110 | | |
111 | 111 | | |
112 | | - | |
113 | | - | |
114 | | - | |
115 | | - | |
116 | | - | |
117 | | - | |
118 | | - | |
119 | | - | |
120 | | - | |
121 | | - | |
122 | | - | |
123 | | - | |
124 | | - | |
125 | | - | |
126 | | - | |
127 | | - | |
128 | | - | |
129 | | - | |
130 | | - | |
131 | | - | |
132 | | - | |
133 | | - | |
134 | | - | |
135 | | - | |
136 | | - | |
137 | | - | |
138 | | - | |
139 | | - | |
140 | | - | |
141 | | - | |
142 | | - | |
143 | | - | |
144 | | - | |
145 | | - | |
146 | | - | |
147 | | - | |
148 | | - | |
| 112 | + | |
149 | 113 | | |
150 | 114 | | |
151 | 115 | | |
| |||
164 | 128 | | |
165 | 129 | | |
166 | 130 | | |
167 | | - | |
| 131 | + | |
168 | 132 | | |
169 | 133 | | |
170 | 134 | | |
| 135 | + | |
| 136 | + | |
| 137 | + | |
| 138 | + | |
| 139 | + | |
| 140 | + | |
| 141 | + | |
| 142 | + | |
| 143 | + | |
| 144 | + | |
| 145 | + | |
| 146 | + | |
| 147 | + | |
| 148 | + | |
| 149 | + | |
| 150 | + | |
| 151 | + | |
| 152 | + | |
171 | 153 | | |
172 | | - | |
| 154 | + | |
| 155 | + | |
173 | 156 | | |
174 | 157 | | |
175 | 158 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
62 | 62 | | |
63 | 63 | | |
64 | 64 | | |
65 | | - | |
| 65 | + | |
| 66 | + | |
66 | 67 | | |
67 | 68 | | |
68 | 69 | | |
| |||
269 | 270 | | |
270 | 271 | | |
271 | 272 | | |
272 | | - | |
| 273 | + | |
| 274 | + | |
| 275 | + | |
| 276 | + | |
| 277 | + | |
| 278 | + | |
273 | 279 | | |
274 | | - | |
275 | | - | |
276 | | - | |
277 | | - | |
278 | | - | |
279 | | - | |
280 | | - | |
281 | | - | |
| 280 | + | |
| 281 | + | |
| 282 | + | |
282 | 283 | | |
283 | 284 | | |
284 | 285 | | |
| |||
0 commit comments