Reuse installed ginkgo and use cleaner binary check#717
Open
jorbaum wants to merge 4 commits intocloudfoundry:mainfrom
Open
Reuse installed ginkgo and use cleaner binary check#717jorbaum wants to merge 4 commits intocloudfoundry:mainfrom
jorbaum wants to merge 4 commits intocloudfoundry:mainfrom
Conversation
cf-foundation-community-automation
bot
moved this to Inbox
in Application Runtime Platform Working Group
This was referenced Feb 24, 2026
This avoids recompiling ginkgo every time
closeDrains() iterates over drain holders and calls drainHolder.cancel()
..but Close() is actually never called. This should not matter though as the place to call it is where the ForwarderAgent is stopped anyway.
jorbaum
force-pushed
the
minor-test-script-improvements
branch
from
3e50a8b to
8f021ec
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
While working on cloudfoundry/go-loggregator#79 I found two things that I found worth adding to the test scripts:
Type of change
Testing performed?
Checklist:
mainbranch, or relevant version branch