Skip to content

Replace use of grpc.Dial and grpc.DialContext with grpc.NewClient #229

@ctlong

Description

@ctlong

Recently the gRPC Go maintainers shared their intention to deprecate grpc.Dial and grpc.DialContext and encourage users to use grpc.NewClient instead.

go-loggregator accepts arbitrary grpc.DialOptions, some of which will not be honoured after switching to grpc.NewClient. As a result when we switch we should major version bump our module.

Current plan is:

  • Wait for gRPC Go project to cut a release that deprecates grpc.Dial and grpc.DialContext.
  • Update the loggregator-api to reflect a new major version of go-loggregator, and re-generate the associated RPC code in go-loggregator.
  • Bump our module version and cut a new release with release notes that indicate that specific dial options will no longer be honoured.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions