Conversation
ctlong
left a comment
ctlong
left a comment
There was a problem hiding this comment.
Just a few minor questions and concerns, otherwise LGTM.
Also, could you please link me somewhere where I could see what this origin flag adds? Why do y'all want to add it?
silvestre
force-pushed
the
add-user-origin
branch
from
0f8e6db to
d98229a
Compare
Adds support to specify the user origin that will be used when using `cf auth`. Co-authored-by: Gareth Evans <[email protected]>
silvestre
force-pushed
the
add-user-origin
branch
from
d98229a to
d8b6f38
Compare
We want to be able to re-use our ASATS (App-Autoscaler acceptance test suite) internally at SAP. However, at SAP the default identity provider is SAP ID service. This means users created by So, to be able to run the ASATS internally, we need to be able to target the correct identity provider ( I hope this specific reason is good enough to get this change in, as in the end we just add the ability to support a feature that is already in CF also in tests. |
Due to [changes in cf-test-helpers](cloudfoundry/cf-test-helpers#92), we need to update our interface and interface implementation to include some new methods. As no one's asking for multiple origin support in CATs, I didn't actually make it available via the integration_config. That's a trivial change if we want to add it in the future.
Due to [changes in cf-test-helpers](cloudfoundry/cf-test-helpers#92), we need to update our interface and interface implementation to include some new methods. As no one's asking for multiple origin support in CATs, I didn't actually make it available via the integration_config. That's a trivial change if we want to add it in the future.
2 participants
Adds support to specify the user origin that will be used when using
cf auth.Co-authored-by: Gareth Evans [email protected]