Skip to content

Remove hostname flag from Push#71

Merged
ctlong merged 1 commit intomainfrom
fix/remove-route-option-from-push
Sep 27, 2022
Merged

Remove hostname flag from Push#71
ctlong merged 1 commit intomainfrom
fix/remove-route-option-from-push

Conversation

@ctlong
Copy link
Copy Markdown
Member

@ctlong ctlong commented Sep 27, 2022

The cf CLI removed --hostname and -d flags from cf push back in v7.0.0. We should not support these options anymore either.

This change will cause -d to be silently ignored if passed into Push().

The cf CLI removed `--hostname` and `-d` flags from `cf push` back in
v7.0.0. We should not support these options anymore either.
@ctlong ctlong linked an issue Sep 27, 2022 that may be closed by this pull request
@ctlong ctlong requested review from a team September 27, 2022 03:36
@ctlong
Copy link
Copy Markdown
Member Author

ctlong commented Sep 27, 2022

We should cut a minor version of cf-test-helpers after this is merged.

@ctlong ctlong removed the request for review from a team September 27, 2022 03:50
@ctlong ctlong merged commit 31eca81 into main Sep 27, 2022
@ctlong ctlong deleted the fix/remove-route-option-from-push branch September 27, 2022 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove -d flag option from push

2 participants