Skip to content

Acceptance tests for service credential binding rotations#1870

Merged
jochenehret merged 1 commit intodevelopfrom
service-credential-binding-rotation
Mar 20, 2026
Merged

Acceptance tests for service credential binding rotations#1870
jochenehret merged 1 commit intodevelopfrom
service-credential-binding-rotation

Conversation

@jochenehret
Copy link
Copy Markdown
Contributor

@jochenehret jochenehret commented Mar 16, 2026

What is this change about?

New acceptance tests for the service credential binding rotations feature.

The first test creates one service binding for the test app / test service and records its guid. Then it creates a second binding (with the multiple strategy), restages the test app and ensures that the binding guid has changed. This validates the full "credential rotation" scenario.

The other tests create two service bindings for the test app / test service and then check the following actions:

  1. cf service <service name> shows all bindings
  2. cf unbind-service <app name> <service name> deletes all bindings
  3. cf cleanup-outdated-service-bindings deletes the oldest binding

Please provide contextual information.

https://github.com/cloudfoundry/community/blob/main/toc/rfc/rfc-0040-service-binding-rotation.md

What version of cf-deployment have you run this cf-acceptance-test change against?

v54.14.0 (with cc.max_service_credential_bindings_per_app_service_instance set to 2)

Please check all that apply for this PR:

  • introduces a new test --- Are you sure everyone should be running this test?
  • changes an existing test
  • requires an update to a CATs integration-config (new config option include_service_credential_binding_rotation, default is false)

Did you update the README as appropriate for this change?

  • YES
  • N/A

If you are introducing a new acceptance test, what is your rationale for including it CATs rather than your own acceptance test suite?

This is a new major CF feature, see RFC-0040.

How many more (or fewer) seconds of runtime will this change introduce to CATs?

Each test takes about 4 minutes to complete, so an additional of 12 minutes (if test suite is enabled).

What is the level of urgency for publishing this change?

  • Urgent - unblocks current or future work
  • Slightly Less than Urgent

@jochenehret jochenehret marked this pull request as draft March 17, 2026 12:48
@jochenehret jochenehret force-pushed the service-credential-binding-rotation branch from 339607d to 48d79c7 Compare March 17, 2026 13:57
@jochenehret jochenehret marked this pull request as ready for review March 17, 2026 13:58
@jochenehret jochenehret requested review from a team March 18, 2026 13:21
Copy link
Copy Markdown

@oliver-heinrich oliver-heinrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@Milena-Encheva, can you also review and approve?

@jochenehret jochenehret merged commit 5c903fe into develop Mar 20, 2026
3 checks passed
@jochenehret jochenehret deleted the service-credential-binding-rotation branch March 20, 2026 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants