Acceptance tests for service credential binding rotations#1870
Merged
jochenehret merged 1 commit intodevelopfrom Mar 20, 2026
Merged
Acceptance tests for service credential binding rotations#1870jochenehret merged 1 commit intodevelopfrom
jochenehret merged 1 commit intodevelopfrom
Conversation
339607d to
48d79c7
Compare
18 tasks
oliver-heinrich
approved these changes
Mar 18, 2026
oliver-heinrich
left a comment
There was a problem hiding this comment.
LGTM
@Milena-Encheva, can you also review and approve?
philippthun
approved these changes
Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this change about?
New acceptance tests for the service credential binding rotations feature.
The first test creates one service binding for the test app / test service and records its guid. Then it creates a second binding (with the
multiplestrategy), restages the test app and ensures that the binding guid has changed. This validates the full "credential rotation" scenario.The other tests create two service bindings for the test app / test service and then check the following actions:
cf service <service name>shows all bindingscf unbind-service <app name> <service name>deletes all bindingscf cleanup-outdated-service-bindingsdeletes the oldest bindingPlease provide contextual information.
https://github.com/cloudfoundry/community/blob/main/toc/rfc/rfc-0040-service-binding-rotation.md
What version of cf-deployment have you run this cf-acceptance-test change against?
v54.14.0 (with
cc.max_service_credential_bindings_per_app_service_instanceset to2)Please check all that apply for this PR:
include_service_credential_binding_rotation, default is false)Did you update the README as appropriate for this change?
If you are introducing a new acceptance test, what is your rationale for including it CATs rather than your own acceptance test suite?
This is a new major CF feature, see RFC-0040.
How many more (or fewer) seconds of runtime will this change introduce to CATs?
Each test takes about 4 minutes to complete, so an additional of 12 minutes (if test suite is enabled).
What is the level of urgency for publishing this change?