Skip to content

Remove unused dependency from the node asset#1694

Merged
davewalter merged 1 commit intodevelopfrom
remove-node-dependency
Sep 30, 2025
Merged

Remove unused dependency from the node asset#1694
davewalter merged 1 commit intodevelopfrom
remove-node-dependency

Conversation

@davewalter
Copy link
Copy Markdown
Member

@davewalter davewalter commented Sep 29, 2025

Are you submitting this PR against the develop branch?

Yes

What is this change about?

Recent changes to the node asset left a reference to the "ip" NPM package in the
package.json file, even though it is not used in the actual application. This PR
removes the unused dependency.

Please provide contextual information.

The dependency in the node asset's package.json causes unnecessary
downloads from npmjs.org when the app is pushed to a foundation.

What version of cf-deployment have you run this cf-acceptance-test change against?

Latest

Please check all that apply for this PR:

  • introduces a new test --- Are you sure everyone should be running this test?
  • changes an existing test
  • requires an update to a CATs integration-config

Did you update the README as appropriate for this change?

  • YES
  • N/A

If you are introducing a new acceptance test, what is your rationale for including it CATs rather than your own acceptance test suite?

N/A

How many more (or fewer) seconds of runtime will this change introduce to CATs?

N/A

What is the level of urgency for publishing this change?

  • Urgent - unblocks current or future work
  • Slightly Less than Urgent

Tag your pair, your PM, and/or team!

It's helpful to tag a few other folks on your team or your team alias in case we need to follow up later.

@davewalter davewalter requested review from a team September 29, 2025 23:05
@davewalter davewalter merged commit da87fd7 into develop Sep 30, 2025
3 checks passed
@davewalter davewalter deleted the remove-node-dependency branch September 30, 2025 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants