Skip to content

Update syslog_drain.go#1691

Merged
philippthun merged 1 commit intodevelopfrom
davewalter-patch-1
Sep 29, 2025
Merged

Update syslog_drain.go#1691
philippthun merged 1 commit intodevelopfrom
davewalter-patch-1

Conversation

@davewalter
Copy link
Copy Markdown
Member

Are you submitting this PR against the develop branch?

Yes.

What is this change about?

Use the TCP domain config helper to support users who override the default value.

Please provide contextual information.

If you use a non-standard TCP domain, the app syslog tests fail.

What version of cf-deployment have you run this cf-acceptance-test change against?

Latest.

Please check all that apply for this PR:

  • introduces a new test --- Are you sure everyone should be running this test?
  • changes an existing test
  • requires an update to a CATs integration-config

Did you update the README as appropriate for this change?

  • YES
  • N/A

If you are introducing a new acceptance test, what is your rationale for including it CATs rather than your own acceptance test suite?

N/A

How many more (or fewer) seconds of runtime will this change introduce to CATs?

N/A

What is the level of urgency for publishing this change?

  • Urgent - unblocks current or future work
  • Slightly Less than Urgent

Tag your pair, your PM, and/or team!

It's helpful to tag a few other folks on your team or your team alias in case we need to follow up later.

Use the TCP domain config helper to support users who override the default value.
@davewalter davewalter requested review from a team September 28, 2025 22:40
@philippthun philippthun merged commit c4d9449 into develop Sep 29, 2025
3 checks passed
@philippthun philippthun deleted the davewalter-patch-1 branch September 29, 2025 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants