Ipv6 validation for Golang#1564
Merged
dimivel merged 3 commits intocloudfoundry:developfrom May 21, 2025
Merged
Conversation
|
Hi @jochenehret , seems that only approvers can add reviewers to the PR. Aftab and Dimitar are currently not available...can you add the reviewers? |
jochenehret
requested changes
May 14, 2025
Contributor
jochenehret
left a comment
jochenehret
left a comment
There was a problem hiding this comment.
Looks good, I just found a wrong test description.
jochenehret
reviewed
May 15, 2025
ipv6/ipv6.go
Outdated
| @@ -82,7 +82,7 @@ var _ = IPv6Describe("IPv6 Connectivity Tests", func() { | |||
| }) | |||
|
|
|||
| Context(fmt.Sprintf("Using Node.js stack: %s", stack), func() { | |||
Contributor
There was a problem hiding this comment.
This line still refers to "Node.js"
jochenehret
approved these changes
May 16, 2025
dimivel
approved these changes
May 21, 2025
iaftab-alam
added a commit
to sap-contributions/cf-acceptance-tests
that referenced
this pull request
May 21, 2025
7 tasks
iaftab-alam
added a commit
to sap-contributions/cf-acceptance-tests
that referenced
this pull request
May 21, 2025
iaftab-alam
added a commit
to sap-contributions/cf-acceptance-tests
that referenced
this pull request
May 21, 2025
iaftab-alam
added a commit
that referenced
this pull request
May 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Are you submitting this PR against the develop branch?
Yes.
What is this change about?
The change is part of the ipv6 egress validation cycle. We progressively extend all of the exciting buildpacks relevant to our ecosystem. In this PR we provide additional endpoints in the Golang application for testing IPv6 support. In case ipv6 validation is enabled, we verify that egress ipv6 call are possible with Go applications.
Please provide contextual information.
https://github.com/cloudfoundry/community/blob/main/toc/rfc/rfc-0038-ipv6-dual-stack-for-cf.md
What version of cf-deployment have you run this cf-acceptance-test change against?
v48.9.0
Please check all that apply for this PR:
Did you update the README as appropriate for this change?
If you are introducing a new acceptance test, what is your rationale for including it CATs rather than your own acceptance test suite?
_CATs should validate IPv6 egress calls with Golang application. We add changes regarding to this buildpack only. The test group for ipv6 was already created.
How many more (or fewer) seconds of runtime will this change introduce to CATs?
Around 90 seconds per test.
What is the level of urgency for publishing this change?
Tag your pair, your PM, and/or team!
@oliver-heinrich @iaftab-alam