Merged
Conversation
ctlong
approved these changes
May 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Are you submitting this PR against the develop branch?
Yes
What is this change about?
With the current dev-release of CAPI, this test is no longer valid. You can push an app without specifying a particular buildpack, as CNBs now have a system support (and with that, buildpack detection)
We are still working on replacing this with more extensive acceptance tests.
Please provide contextual information.
You can see where we removed the error: https://github.com/cloudfoundry/cloud_controller_ng/pull/3898/files#diff-1c0ac13c424df7993b1515f0f18b2b3358a1889688c0aa22c62381a3b3a7c7c9L492
What version of cf-deployment have you run this cf-acceptance-test change against?
n/a, this is for a pre-release CAPI.
Please check all that apply for this PR:
Did you update the README as appropriate for this change?
If you are introducing a new acceptance test, what is your rationale for including it CATs rather than your own acceptance test suite?
CATs should validate common operator workflows.
CATs is not a regression test suite.
CATs is run by every component team to validate their releases before promotion.
How many more (or fewer) seconds of runtime will this change introduce to CATs?
What is the level of urgency for publishing this change?
Tag your pair, your PM, and/or team!
It's helpful to tag a few other folks on your team or your team alias in case we need to follow up later.