Skip to content

remove unnneeded global rand.Seed logic#1500

Merged
ctlong merged 1 commit intodevelopfrom
remove-global-seed
Mar 21, 2025
Merged

remove unnneeded global rand.Seed logic#1500
ctlong merged 1 commit intodevelopfrom
remove-global-seed

Conversation

@ameowlia
Copy link
Copy Markdown
Member

since go 1.20 rand has been automatically seeded

Are you submitting this PR against the develop branch?

Yes

What is this change about?

Calling rand.Seed globally is no longer needed. Since go 1.20 rand has been automatically seeded. go 1.20 was released in Feb 2022 and is no longer supported.

Please provide contextual information.

What version of cf-deployment have you run this cf-acceptance-test change against?

Please check all that apply for this PR:

  • introduces a new test --- Are you sure everyone should be running this test?
  • changes an existing test
  • requires an update to a CATs integration-config

Did you update the README as appropriate for this change?

  • YES
  • N/A

If you are introducing a new acceptance test, what is your rationale for including it CATs rather than your own acceptance test suite?

n/a

How many more (or fewer) seconds of runtime will this change introduce to CATs?

micoseconds faster!

What is the level of urgency for publishing this change?

  • Urgent - unblocks current or future work
  • Slightly Less than Urgent

Tag your pair, your PM, and/or team!

It's helpful to tag a few other folks on your team or your team alias in case we need to follow up later.

since go 1.20 rand has been automatically seeded
Copy link
Copy Markdown
Member

@ctlong ctlong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to take the microseconds back! Thanks!

@ctlong ctlong self-assigned this Mar 21, 2025
@ctlong ctlong merged commit 38f80d2 into develop Mar 21, 2025
3 checks passed
@ctlong ctlong deleted the remove-global-seed branch March 21, 2025 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants