Skip to content

Add X-CF-PROCESS-INSTANCE header tests for routing#1463

Merged
ctlong merged 1 commit intocloudfoundry:developfrom
Samze:process_routing
May 7, 2025
Merged

Add X-CF-PROCESS-INSTANCE header tests for routing#1463
ctlong merged 1 commit intocloudfoundry:developfrom
Samze:process_routing

Conversation

@Samze
Copy link
Copy Markdown
Contributor

@Samze Samze commented Feb 26, 2025 •
edited
Loading

  • X-CF-PROCESS-INSTANCE:<process_guid>
  • X-CF-PROCESS-INSTANCE:<process_guid>:<instance_index>

note This should not be merged until the work has been complete in GoRouter and released in cfd.

Are you submitting this PR against the develop branch?

Yes

What is this change about?

Add CATs test for ability to route to a specific process and process instance.

Please provide contextual information.

What version of cf-deployment have you run this cf-acceptance-test change against?

Please check all that apply for this PR:

  • introduces a new test --- Are you sure everyone should be running this test?
  • changes an existing test
  • requires an update to a CATs integration-config

Did you update the README as appropriate for this change?

  • YES
  • N/A

How many more (or fewer) seconds of runtime will this change introduce to CATs?


Ran 1 of 250 Specs in 136.660 seconds
SUCCESS! -- 1 Passed | 0 Failed | 2 Pending | 247 Skipped
PASS | FOCUSED

What is the level of urgency for publishing this change?

  • Urgent - unblocks current or future work
  • Slightly Less than Urgent

@Samze
Add X-CF-PROCESS-INSTANCE header tests for routing
98428d9 
* X-CF-PROCESS-INSTANCE:<process_guid>
* X-CF-PROCESS-INSTANCE:<process_guid>:<index>
Samze
Samze commented Feb 26, 2025
View reviewed changes
routing/process_routing.go
})

Describe("the X-CF-PROCESS-INSTANCE header", func() {
It("can be used to route requests to the correct process and instance", func() {
Copy link
Copy Markdown
Contributor Author

@Samze Samze Feb 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note One giant IT to minimise test run time.

@Samze
Copy link
Copy Markdown
Contributor Author

Samze commented Feb 28, 2025

cc @tcdowney

@Samze
Copy link
Copy Markdown
Contributor Author

Samze commented Mar 18, 2025

Implemented PR https://github.com/cloudfoundry/gorouter/pull/467/files

@Samze
Copy link
Copy Markdown
Contributor Author

Samze commented Mar 26, 2025

Added in routing release 0.332.0, waiting for inclusion in cf-d.

@Samze
Copy link
Copy Markdown
Contributor Author

Samze commented Apr 1, 2025

Added to https://github.com/cloudfoundry/cf-deployment/releases/tag/v48.7.0

@Samze Samze marked this pull request as ready for review April 4, 2025 16:31
@ctlong ctlong self-assigned this Apr 18, 2025
@ctlong ctlong merged commit 75249a7 into cloudfoundry:develop May 7, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ctlong ctlong ctlong approved these changes

+1 more reviewer

@sethboyles sethboyles sethboyles approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@ctlong ctlong

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Samze @sethboyles @ctlong