Fix Elastic IP association for instances with multiple network interfaces#194
Merged
aramprice merged 10 commits intocloudfoundry:masterfrom Mar 12, 2026
Merged
Conversation
This was referenced Jan 15, 2026
dudejas
reviewed
Jan 15, 2026
…c_group attribute and updating association logic
aramprice
reviewed
Feb 26, 2026
aramprice
previously approved these changes
Feb 26, 2026
aramprice
approved these changes
Mar 5, 2026
ay901246
reviewed
Mar 12, 2026
aramprice
approved these changes
Mar 12, 2026
ay901246
reviewed
Mar 12, 2026
ay901246
reviewed
Mar 12, 2026
ay901246
left a comment
There was a problem hiding this comment.
Leaving two comments, one around deterministic indexing and the other around retries/exponential backoff.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When deploying BOSH instances with multiple network interfaces (using different
nic_groupconfigurations) and an Elastic IP, the CPI fails duringcreate_vmwith:Additionally, there was no way to control which NIC receives the Elastic IP in multi-NIC configurations.
Root Cause
The
associate_addressAWS API call was using theinstance_idparameter, which according to AWS documentation only works when "the instance must have exactly one attached network interface."AWS Documentation Reference
From the AWS EC2 AssociateAddress API Documentation:
InstanceId parameter:
NetworkInterfaceId parameter:
Solution
Multi-NIC Elastic IP fix:
network_interface_idinstead ofinstance_idinassociate_addresscallnic_group support for VIP networks:
nic_groupin deployment manifestAdditional improvements:
Depends on cloudfoundry/bosh#2658