Skip to content

Add support for dynamic disks#393

Merged
mariash merged 2 commits intocloudfoundry:mainfrom
mariash:add-dynamic-disks
Mar 24, 2026
Merged

Add support for dynamic disks#393
mariash merged 2 commits intocloudfoundry:mainfrom
mariash:add-dynamic-disks

Conversation

@mariash
Copy link
Copy Markdown
Member

@mariash mariash commented Dec 15, 2025

This PR introduces agent-side handling for attach and detach lifecycle operations for dynamically provisioned disks. It adds 2 agent actions:

  • add_dynamic_disk - resolves dynamic disk path for provided disk hint and creates a symlink /var/vcap/data/dynamic_disks/<diskID>
  • remove_dynamic_disk - removes the symlink /var/vcap/data/dynamic_disks/<diskID>

Please refer to the corresponding Director PR - cloudfoundry/bosh#2652

@mariash mariash changed the title Add dynamic disks Add support for dynamic disks Dec 15, 2025
@mariash mariash closed this Dec 15, 2025
@mariash mariash reopened this Dec 15, 2025
@mariash mariash marked this pull request as ready for review December 16, 2025 00:04
@rkoster
Copy link
Copy Markdown
Contributor

rkoster commented Dec 18, 2025

As discussed during the FI working group meeting, a change like this especially if it is gonna be used by something like diego needs an RFC. For more information about the RFC process please look here: https://github.com/cloudfoundry/community

@aramprice aramprice requested review from a team, KauzClay and benjaminguttmann-avtq and removed request for a team January 29, 2026 16:17
@aramprice aramprice moved this from Inbox to Pending Review | Discussion in Foundational Infrastructure Working Group Jan 29, 2026
@aramprice aramprice marked this pull request as draft March 12, 2026 15:56
@aramprice
Copy link
Copy Markdown
Member

Converting to draft until cloudfoundry/community#1401 is accepted

@mariash mariash marked this pull request as ready for review March 20, 2026 22:20
@mariash
Copy link
Copy Markdown
Member Author

mariash commented Mar 20, 2026

Marking as "Ready for review" since RFC is in FCP.

@mariash mariash requested a review from rkoster March 20, 2026 22:22
mariash added 2 commits March 22, 2026 06:21
It will resolve disk path based on hint and create symlink in data directory
It will delete the symlink to real device path in
/var/vcap/data/dynamic_disks
@mariash mariash force-pushed the add-dynamic-disks branch from ca75226 to 2f17cf9 Compare March 22, 2026 06:21
@github-project-automation github-project-automation bot moved this from Pending Review | Discussion to Pending Merge | Prioritized in Foundational Infrastructure Working Group Mar 24, 2026
@mariash mariash merged commit b870cb5 into cloudfoundry:main Mar 24, 2026
10 checks passed
@github-project-automation github-project-automation bot moved this from Pending Merge | Prioritized to Done in Foundational Infrastructure Working Group Mar 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

4 participants