Pick a non-conflicting env name for fips bats#2693
Merged
Conversation
Leftovers uses substring matching to decide which resources to destroy, so we CANNOT share any substrings involved in cleanup with ANY other resources. Using just "fips" lead to the unintentional deletion of several buckets not related to the fips bats tests: https://bosh.ci.cloudfoundry.org/teams/main/pipelines/bosh-director/jobs/bats-fips-cleanup-leftovers/builds/468#L69a9299f:936:937 ai-assisted=yes
cf-foundation-community-automation
bot
moved this to Inbox
in Foundational Infrastructure Working Group
beyhan
approved these changes
Mar 13, 2026
github-project-automation
bot
moved this from Inbox
to Pending Merge | Prioritized
in Foundational Infrastructure Working Group
rkoster
approved these changes
Mar 13, 2026
aramprice
approved these changes
Mar 13, 2026
github-project-automation
bot
moved this from Pending Merge | Prioritized
to Done
in Foundational Infrastructure Working Group
Member
Author
|
Flew the pipeline as well |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Leftovers uses substring matching to decide which resources to destroy, so we CANNOT share any substrings involved in cleanup with ANY other resources.
Using just "fips" lead to the unintentional deletion of several buckets not related to the fips bats tests:
https://bosh.ci.cloudfoundry.org/teams/main/pipelines/bosh-director/jobs/bats-fips-cleanup-leftovers/builds/468#L69a9299f:936:937