Conversation
selzoc
requested changes
Mar 10, 2026
| - create-bosh-candidate-release-compiled | ||
| - bats | ||
| - bats-cleanup-leftovers | ||
| - bats-fips |
Member
There was a problem hiding this comment.
Do we need to rename the job? This'll cause us to lose history (unless we do a multiple fly with old_name
aramprice
reviewed
Mar 10, 2026
| GCP_JSON_KEY: ((gcp_json_key)) | ||
|
|
||
| - name: bats-fips | ||
| - name: fips-bats |
Member
There was a problem hiding this comment.
When you re-fly it might be good to add:
old_name: bats-fips
So that the build history is carried over.
aramprice
previously approved these changes
Mar 10, 2026
bats cleanup task was deleting objects starting with "bats" which included "bats-fips" and caused "bats-fips" to fail.
mariash
force-pushed
the
bats-fips-rename
branch
from
010650e to
c6ce579
Compare
selzoc
approved these changes
Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this change about?
bats cleanup task was deleting objects starting with "bats" which included "bats-fips" and caused "bats-fips" to fail.
Please provide contextual information.
bats-fips tests start failing in the middle of the run with bosh command errors like EOF. If bats tests have finished and ran cleanup they deleted all "bats-fips" objects.
Does this PR introduce a breaking change?
No