Conversation
Three specs relied on database row ordering that isn't guaranteed across different DB engines or parallel test runs: - instance_network_reservations_spec: use contain_exactly instead of eq for nic_group assertions since ip_addresses association order is non-deterministic - scan_and_fix_spec: use DeploymentProblem.order(:id) instead of .all when indexing by position, since .all doesn't guarantee order - package_persister_spec: use Package.order(:name) and explicit where clause instead of .all with positional indexing Made-with: Cursor
The test expected deployment names in a specific order in the error message, but stemcell.deployments returns results in non-deterministic order. Use a regex matcher to accept either ordering. Made-with: Cursor
aramprice
requested review from
a team,
a-hassanin and
mkocher
and removed request for
a team
cf-foundation-community-automation
bot
moved this to Inbox
in Foundational Infrastructure Working Group
mariash
approved these changes
Feb 26, 2026
github-project-automation
bot
moved this from Inbox
to Pending Merge | Prioritized
in Foundational Infrastructure Working Group
github-project-automation
bot
moved this from Pending Merge | Prioritized
to Done
in Foundational Infrastructure Working Group
Member
|
Thank you @aramprice! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes non-determinism in spec expectations using Cursor / claude-4.6-opus-high
This should address most of the recent failures in github actions:
https://github.com/cloudfoundry/bosh/actions/workflows/ruby.yml?query=is%3Afailure+branch%3Amain