add prefix to network settings for dynamic and vip network#2641
Merged
add prefix to network settings for dynamic and vip network#2641
Conversation
aramprice
approved these changes
Nov 18, 2025
Member
|
Manually running integration specs: Specs are still running but it looks like there are some failures around ordering of IP's in expected return values. Not sure if this ordering is important but it appears to have changed. An partial excerpt from the output of the spec run above: |
aramprice
requested changes
Nov 18, 2025
7f158eb to
2806791
Compare
Contributor
Author
|
@aramprice I reran the integration tests and now they are green: https://bosh.ci.cloudfoundry.org/builds/291139895 did not know that you can run those standalone otherwise would have done that before ;) |
aramprice
approved these changes
Nov 20, 2025
Member
|
@fmoehler - thanks this looks good. I think go ahead and merge so we can get the pipeline back in working order. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this change about?
This PR will add the prefix to the network settings of dynamic and vip networks which was previously missed. Although these network types do not support prefix allocation (yet) they should have this property as well to make all network types (manual, dynamic, vip) have the same config.
Please provide contextual information.
This issue was revealed after 9ec3b74#r170570246 was merged.
What tests have you run against this PR?
Reran previously failing integration tests + unit tests.
How should this change be described in bosh release notes?
Set prefix in network_settings of dynamic and vip networkds
Does this PR introduce a breaking change?
No
Tag your pair, your PM, and/or team!
@neddp , @Ivaylogi98 , @mariash