Fix CLI Output for prefix ip addresses#2637
Merged
Conversation
fmoehler
force-pushed
the
fix-cli-prefix-output
branch
from
498af8c to
1408d0a
Compare
fmoehler
changed the title
cf-foundation-community-automation
bot
moved this to Inbox
in Foundational Infrastructure Working Group
rkoster
requested review from
a team,
KauzClay and
selzoc
and removed request for
a team
rkoster
moved this from Inbox
to Pending Review | Discussion
in Foundational Infrastructure Working Group
neddp
approved these changes
Nov 11, 2025
aramprice
approved these changes
Nov 13, 2025
github-project-automation
bot
moved this from Pending Review | Discussion
to Pending Merge | Prioritized
in Foundational Infrastructure Working Group
github-project-automation
bot
moved this from Pending Merge | Prioritized
to Done
in Foundational Infrastructure Working Group
Member
|
Hi Felix, I think this may have broken the integrations specs, based on CI output. More details in 9ec3b74#r170570246 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this change about?
Currently the CLI output looks a little weird when a prefix address is allocated. This PR does two things:
Please provide contextual information.
This commit accidentally removed the prefix information when reading the ip address from the network_spec_json in the vms database table: 5b453b6
This way the cli output looks like this at the moment if a prefix address is assigned:
You can see that the base address of the prefix is being shown twice, once with prefix (correct) and once without prefix (incorrect).
What tests have you run against this PR?
Extended the existing unit tests to take care of this scenario
How should this change be described in bosh release notes?
Fix CLI Output for prefix ip addresses
Does this PR introduce a breaking change?
No