Remove unnecessary -z flag from tar extraction commands#2635
Merged
rkoster merged 1 commit intocloudfoundry:mainfrom Nov 6, 2025
Merged
Remove unnecessary -z flag from tar extraction commands#2635rkoster merged 1 commit intocloudfoundry:mainfrom
rkoster merged 1 commit intocloudfoundry:mainfrom
Conversation
Modern tar implementations support automatic compression detection based on file signatures and fallback to filename suffixes. The -z flag is only required when reading from pipes or tape drives without random access. This change removes the -z flag from tar extraction commands in: - BOSH Director release and stemcell extraction - Job template extraction - Integration test utilities - CI export scripts The changes maintain compatibility with modern tar implementations while simplifying the codebase. Test utilities and pipe-based extractions correctly retain the -z flag where needed. This change is done in preparation for introducing a no-compression flag in the bosh create-release command, which will allow creating uncompressed release tarballs that can be processed with the simplified tar commands.
cf-foundation-community-automation
bot
moved this to Inbox
in Foundational Infrastructure Working Group
Member
|
Running one-off integration suite at: |
aramprice
requested review from
a team,
benjaminguttmann-avtq and
ystros
and removed request for
a team
aramprice
moved this from Inbox
to Pending Review | Discussion
in Foundational Infrastructure Working Group
KauzClay
reviewed
Oct 24, 2025
Contributor
There was a problem hiding this comment.
Just trying to clarify my understanding.
This is related to the --no-compression flag change because the -z flag on non-compressed files will cause tar to fail?
Any by removing the z, since tar can auto-detect, it can safely expand things that were tar-ed without compression?
Contributor
Author
Yep, exactly |
neddp
approved these changes
Oct 27, 2025
rkoster
approved these changes
Nov 6, 2025
github-project-automation
bot
moved this from Pending Review | Discussion
to Pending Merge | Prioritized
in Foundational Infrastructure Working Group
Contributor
|
Merging this PR since it is a non breaking change and a path forward for the UX of the no compression feature has been determined during today's FI working group meeting (this was the previous blocker). |
github-project-automation
bot
moved this from Pending Merge | Prioritized
to Done
in Foundational Infrastructure Working Group
mdzhigarov
added a commit
to mdzhigarov/bosh
that referenced
this pull request
Mar 18, 2026
Follow-up to PR cloudfoundry#2635 which removed the -z flag from tar extraction commands but missed the validate_tgz method in package_persister.rb and its corresponding test expectations. The -z flag forces gzip decompression, causing failures when processing non-gzip-compressed package archives. Modern tar auto-detects the compression format without needing the -z flag. Made-with: Cursor
aramprice
pushed a commit
that referenced
this pull request
Mar 18, 2026
Follow-up to PR #2635 which removed the -z flag from tar extraction commands but missed the validate_tgz method in package_persister.rb and its corresponding test expectations. The -z flag forces gzip decompression, causing failures when processing non-gzip-compressed package archives. Modern tar auto-detects the compression format without needing the -z flag. Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR removes the unnecessary
-zflag from tar extraction commands throughout the BOSH codebase. Modern tar implementations support automatic compression detection based on file signatures and fallback to filename suffixes.Changes Made
update_release.rb,update_stemcell.rb,release_job.rb, andjob_template_loader.rbTechnical Details
The
-zflag is only required when reading from pipes or tape drives without random access. For regular file operations, modern tar implementations can automatically detect compression formats using:.tgz,.tar.gz)Compatibility
-zflag where still needed (pipes, test utilities)Preparation for Future Enhancement
This change is done in preparation for introducing a
--no-compressionflag in thebosh create-releasecommand, which will allow creating uncompressed release tarballs that can be processed with the simplified tar commands.Testing
Exec.shcalls, so they verify error handling behavior rather than specific command syntaxReferences