Fix compile of crc32-pclmul_asm on macOS High Sierra#8
Merged
vkrasnov merged 1 commit intocloudflare:gcc.amd64from May 27, 2018
Merged
Conversation
* .type and .size are ELF/COFF specific so drop them * .globl + .hidden equivalent for macOS is .private_extern * symbol name are not mangled on macOS, so we need to prefix _
Author
|
I tried compiling If I cherry-pick c129738 from this PR into |
|
Ooops, looks like I forgot to commit the fix, only changed the commit message :) |
Author
|
@vkrasnov Have you found the missing commit for mac compatibility? |
|
This is still a problem. |
|
@kornelski I solved this by applying @RJVB's Mac and compatibility fixes #6. While RJVB's code works, it does make some assumptions, e.g. that |
fhanau
pushed a commit
to fhanau/zlib
that referenced
this pull request
Feb 27, 2023
Reference IETF docs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
.typeand.sizeare ELF/COFF specific so drop them.globl+.hiddenequivalent for macOS is.private_extern_prefixThis is similar to #6, but only contains the fixes that are actually required to compile on macOS 10.13.
I have run
make testandmake test64and all tests are passing fine.