Merged
Conversation
Signed-off-by: Ningfei Li <[email protected]>
Also remove 'zconf.h', it will be generated during building.
Clean up. Add option to set runtime (useful for MSVC). Add 'SSE4.2' and 'AVX' option. Signed-off-by: Ningfei Li <[email protected]>
Also remove checking fseeko. Signed-off-by: Ningfei Li <[email protected]>
Signed-off-by: Ningfei Li <[email protected]>
Signed-off-by: Ningfei Li <[email protected]>
Signed-off-by: Ningfei Li <[email protected]>
Signed-off-by: Ningfei Li <[email protected]>
Signed-off-by: Ningfei Li <[email protected]>
SSE4.2 and PCLMUL are also supported.
check_c_compiler_flag detects SSE2, SSE3, SSE42 and PCLMUL but compiling fails. Workaround fix, need further investigation.
vkrasnov
reviewed
Dec 2, 2020
CMakeLists.txt
Outdated
| set(CMAKE_DEBUG_POSTFIX "d") | ||
| add_definitions(-D_CRT_SECURE_NO_DEPRECATE) | ||
| add_definitions(-D_CRT_NONSTDC_NO_DEPRECATE) | ||
| set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} /wd4018") # '<': signed/unsigned mismatch |
There was a problem hiding this comment.
I wonder if we should instead fix those warnings?
Author
There was a problem hiding this comment.
will check it again using MSVC. I think this only happens when we use MSVC.
vkrasnov
reviewed
Dec 2, 2020
| endif() | ||
|
|
||
| # append "inffast_chunk.c" and compile with "sse2" if supported by compiler | ||
| if(HAS_SSE2) |
There was a problem hiding this comment.
Both SSE2 and SSSE3 checks are redundant, since they are present on all x86-64 CPUs anyway.
Author
There was a problem hiding this comment.
Okay, then I will add the flags and definitions directly. I added these two checks just recently since I saw they were checked in the configure
vkrasnov
approved these changes
Dec 2, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is part of the efforts @neurolabusc and I started to fix and tweak the compiling using CMake, especially on Windows. Some parts had already been merged in #19. The current PR further includes:
comments are welcome :)