Skip to content

Migrate prereleases to pkg-pr-new#9492

Merged
penalosa merged 15 commits intomainfrom
penalosa/pgk-pr-new
Jun 5, 2025
Merged

Migrate prereleases to pkg-pr-new#9492
penalosa merged 15 commits intomainfrom
penalosa/pgk-pr-new

Conversation

@penalosa
Copy link
Copy Markdown
Contributor

@penalosa penalosa commented Jun 5, 2025 •
edited
Loading

Migrate from our custom pre-release registry to https://github.com/stackblitz-labs/pkg.pr.new, which allows us to offload a bunch of code.

Several things to note:

  • There are several other repos using our prerelease registry. As such, while this PR deletes the Worker's source, the running Worker will continue to work and prereleases on those repo's won't break. However, we should consider migrating those repos in future. For completeness, they're: next-on-pages (cc @dario-piotrowicz), pages-plugins (cc @GregBrimble), chanfana (cc @G4brym).
  • Our current setup supports prereleases for VSCode extensions in addition to packages. However, the extension that this was built for is on pause, and so it's not a priority to support this use case. We can easily expand to support it in future.
  • This setup supports prereleases for branches in addition to PRs, and so I've turned off npm publishing for branch previews (d1/workflows/beta)
  • I've added a label to Wrangler prereleases to make them stand out a bit more:
Screenshot 2025-06-05 at 13 44 31
  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because: This has to be (and has been) manually tested, by trying out one of the pre-releases on the pkg.pr.new comment on this PR
  • Wrangler / Vite E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because: N/A
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: Internal to this repo, and the contributing guide has been updated
  • Wrangler V3 Backport
    • TODO (before merge)
    • Wrangler PR:
    • Not necessary because: not a wrangler change

@penalosa penalosa requested a review from a team as a code owner June 5, 2025 10:58
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Jun 5, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 992ea68

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@penalosa penalosa marked this pull request as draft June 5, 2025 10:58
@github-project-automation github-project-automation Bot moved this to Untriaged in workers-sdk Jun 5, 2025
@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented Jun 5, 2025 •
edited
Loading

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@9492

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@9492

miniflare

npm i https://pkg.pr.new/miniflare@9492

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@9492

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@9492

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@9492

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@9492

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@9492

wrangler

npm i https://pkg.pr.new/wrangler@9492

commit: 992ea68

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 5, 2025 •
edited
Loading

A Wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/15466063264/npm-package-wrangler-9492
Prereleases for other packages:

cloudflare-workers-bindings-extension:

wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/15466063264/npm-package-cloudflare-workers-bindings-extension-9492 -O ./cloudflare-workers-bindings-extension.0.0.10.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.10.vsix

create-cloudflare:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/15466063264/npm-package-create-cloudflare-9492 --no-auto-update

@cloudflare/kv-asset-handler:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/15466063264/npm-package-cloudflare-kv-asset-handler-9492

miniflare:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/15466063264/npm-package-miniflare-9492

@cloudflare/pages-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/15466063264/npm-package-cloudflare-pages-shared-9492

@cloudflare/unenv-preset:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/15466063264/npm-package-cloudflare-unenv-preset-9492

@cloudflare/vite-plugin:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/15466063264/npm-package-cloudflare-vite-plugin-9492

@cloudflare/vitest-pool-workers:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/15466063264/npm-package-cloudflare-vitest-pool-workers-9492

@cloudflare/workers-editor-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/15466063264/npm-package-cloudflare-workers-editor-shared-9492

@cloudflare/workers-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/15466063264/npm-package-cloudflare-workers-shared-9492

@cloudflare/workflows-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/15466063264/npm-package-cloudflare-workflows-shared-9492

Note that these links will no longer work once the GitHub Actions artifact expires.

github-advanced-security[bot]
github-advanced-security AI found potential problems Jun 5, 2025
View reviewed changes
Comment thread .github/workflows/prerelease.yml Fixed
github-advanced-security[bot]
github-advanced-security AI found potential problems Jun 5, 2025
View reviewed changes
Comment thread .github/workflows/prerelease.yml Fixed
github-advanced-security[bot]
github-advanced-security AI found potential problems Jun 5, 2025
View reviewed changes
Comment thread .github/workflows/prerelease.yml Dismissed
@penalosa penalosa changed the title try out pkg-pr-new Migrate prereleases to pkg-pr-new Jun 5, 2025
@penalosa penalosa marked this pull request as ready for review June 5, 2025 12:45
@penalosa penalosa requested a review from a team as a code owner June 5, 2025 12:45
@penalosa penalosa added skip-pr-description-validation Skip validation of the required PR description format no-changeset-required Skip PR check for valid changeset labels Jun 5, 2025
dario-piotrowicz
dario-piotrowicz approved these changes Jun 5, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@dario-piotrowicz dario-piotrowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks for doing this 😄

Comment thread packages/wrangler/src/wrangler-banner.ts
let text =
typeof WRANGLER_PRERELEASE_LABEL === "undefined"
? ` ⛅️ wrangler ${wranglerVersion}`
: ` ⛅️ wrangler ${wranglerVersion} (${chalk.blue(WRANGLER_PRERELEASE_LABEL)})`;
Copy link
Copy Markdown
Member

@dario-piotrowicz dario-piotrowicz Jun 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

dario-piotrowicz
dario-piotrowicz reviewed Jun 5, 2025
View reviewed changes
Comment thread .github/prereleases/upload.mjs Outdated
@Aslemammad
Copy link
Copy Markdown

Aslemammad commented Jun 5, 2025

i was waiting for this moment for a while! thank you all for trusting us.

petebacondarwin
petebacondarwin approved these changes Jun 5, 2025
View reviewed changes
Comment thread .github/workflows/prerelease.yml Outdated
@github-project-automation github-project-automation Bot moved this from Untriaged to Approved in workers-sdk Jun 5, 2025
@penalosa penalosa enabled auto-merge June 5, 2025 16:00
@penalosa penalosa disabled auto-merge June 5, 2025 16:19
@penalosa
Copy link
Copy Markdown
Contributor Author

penalosa commented Jun 5, 2025 •
edited by lrapoport-cf
Loading

For posterity, the D1 & Workflows teams confirmed they are onboard with this approach cc @cloudflare/workflows @cloudflare/d1

@penalosa penalosa removed the skip-pr-description-validation Skip validation of the required PR description format label Jun 5, 2025
@penalosa penalosa enabled auto-merge June 5, 2025 17:28
@penalosa penalosa added this pull request to the merge queue Jun 5, 2025
Merged via the queue into main with commit a937572 Jun 5, 2025
32 of 33 checks passed
@penalosa penalosa deleted the penalosa/pgk-pr-new branch June 5, 2025 17:33
@github-project-automation github-project-automation Bot moved this from Approved to Done in workers-sdk Jun 5, 2025
@geelen geelen mentioned this pull request Jul 2, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@petebacondarwin petebacondarwin petebacondarwin approved these changes

@dario-piotrowicz dario-piotrowicz dario-piotrowicz approved these changes

@lrapoport-cf lrapoport-cf lrapoport-cf approved these changes

Assignees

No one assigned

Labels

no-changeset-required Skip PR check for valid changeset

Projects

workers-sdk
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@penalosa @Aslemammad @petebacondarwin @dario-piotrowicz @github-advanced-security @lrapoport-cf @workers-devprod