Skip to content

fix: make sure c3 does not add duplicated types #11558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
vicb merged 3 commits into from
Dec 8, 2025
Merged

fix: make sure c3 does not add duplicated types #11558

vicb merged 3 commits into from
Dec 8, 2025

Conversation

@vicb
Copy link
Contributor

@vicb vicb commented Dec 8, 2025

What we don't want is (c3/next)

		"types": [
			"./cloudflare-env.d.ts",
			"./cloudflare-env.d.ts",
			"node",
			"node"
		]
  • Tests
    • Tests included/updated
    • Tests not necessary because: tested manually
  • Public documentation
    • Cloudflare docs PR(s):
    • Documentation not necessary because: fix
  • Wrangler V3 Backport
    • Wrangler PR:
    • Not necessary because: c3

A picture of a cute animal (not mandatory, but encouraged)

@vicb vicb requested a review from a team as a code owner December 8, 2025 15:09
@changeset-bot
Copy link

changeset-bot bot commented Dec 8, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: a1c6be4

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-project-automation github-project-automation bot moved this to Untriaged in workers-sdk Dec 8, 2025
@vicb vicb force-pushed the vicb/c3-no-dup-types branch from 8a0aacf to eee6990 Compare December 8, 2025 15:11
@vicb vicb force-pushed the vicb/c3-no-dup-types branch from eee6990 to 236f679 Compare December 8, 2025 15:13
@pkg-pr-new
Copy link

pkg-pr-new bot commented Dec 8, 2025 •
edited
Loading

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@11558

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@11558

miniflare

npm i https://pkg.pr.new/miniflare@11558

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@11558

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@11558

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@11558

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@11558

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@11558

@cloudflare/workers-utils

npm i https://pkg.pr.new/@cloudflare/workers-utils@11558

wrangler

npm i https://pkg.pr.new/wrangler@11558

commit: a1c6be4

@github-project-automation github-project-automation bot moved this from Untriaged to Approved in workers-sdk Dec 8, 2025
@vicb
Copy link
Contributor Author

vicb commented Dec 8, 2025

Thanks for the review Matt!

@vicb vicb merged commit d53462c into main Dec 8, 2025
30 checks passed
@vicb vicb deleted the vicb/c3-no-dup-types branch December 8, 2025 16:52
@github-project-automation github-project-automation bot moved this from Approved to Done in workers-sdk Dec 8, 2025
@workers-devprod workers-devprod mentioned this pull request Dec 8, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ascorbic ascorbic ascorbic approved these changes

Assignees

No one assigned

Labels

None yet

Projects

workers-sdk
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vicb @ascorbic