Skip to content

Un-quarantine the RedwoodSDK C3 e2e test and bump create-rwsdk to 3.1.1 #11557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dario-piotrowicz merged 4 commits into from
Dec 8, 2025
Merged

Un-quarantine the RedwoodSDK C3 e2e test and bump create-rwsdk to 3.1.1 #11557

dario-piotrowicz merged 4 commits into from
Dec 8, 2025
+15 −3

Conversation

@dario-piotrowicz
Copy link
Member

@dario-piotrowicz dario-piotrowicz commented Dec 8, 2025 •
edited
Loading

This PR reverts the changes in #11554 since [email protected] has been released

It also bumps the create-rwsdk version to 3.1.1

  • Tests
    • Tests included/updated
    • Tests not necessary because:
  • Public documentation
    • Cloudflare docs PR(s):
    • Documentation not necessary because: tests change
  • Wrangler V3 Backport
    • Wrangler PR:
    • Not necessary because: not a Wrangler change

@dario-piotrowicz dario-piotrowicz requested a review from a team as a code owner December 8, 2025 14:11
@changeset-bot
Copy link

changeset-bot bot commented Dec 8, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: 925d9d0

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-project-automation github-project-automation bot moved this to Untriaged in workers-sdk Dec 8, 2025
@jamesopstad
Copy link
Contributor

jamesopstad commented Dec 8, 2025

Thanks. Could you address #11554 (comment) in this PR so we can do both changes in one?

@pkg-pr-new
Copy link

pkg-pr-new bot commented Dec 8, 2025 •
edited
Loading

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@11557

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@11557

miniflare

npm i https://pkg.pr.new/miniflare@11557

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@11557

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@11557

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@11557

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@11557

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@11557

@cloudflare/workers-utils

npm i https://pkg.pr.new/@cloudflare/workers-utils@11557

wrangler

npm i https://pkg.pr.new/wrangler@11557

commit: 925d9d0

@dario-piotrowicz dario-piotrowicz added no-changeset-required skip-v3-pr Skip validation of presence of a v3 backport PR labels Dec 8, 2025
@dario-piotrowicz
Copy link
Member Author

dario-piotrowicz commented Dec 8, 2025

Thanks. Could you address #11554 (comment) in this PR so we can do both changes in one?

right! done 🙂👍 3e0c76c

@github-project-automation github-project-automation bot moved this from Untriaged to Approved in workers-sdk Dec 8, 2025
vicb
vicb reviewed Dec 8, 2025
View reviewed changes
Copy link
Contributor

@vicb vicb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this PR update create-rwsdk as well ?

@dario-piotrowicz dario-piotrowicz mentioned this pull request Dec 8, 2025
Merged
6 tasks
@dario-piotrowicz
Copy link
Member Author

dario-piotrowicz commented Dec 8, 2025 •
edited
Loading

Should this PR update create-rwsdk as well ?

I think that it's not necessary.... but also yeah it wouldn't hurt 🙂👍

Yeah, definitely! thanks for pointing that out! 👍

@dario-piotrowicz dario-piotrowicz changed the title Un-quarantine the RedwoodSDK C3 e2e test Un-quarantine the RedwoodSDK C3 e2e test and bump create-rwsdk to 3.1.1 Dec 8, 2025
@dario-piotrowicz
Copy link
Member Author

dario-piotrowicz commented Dec 8, 2025

Oh no.... it looks like something might be wrong with @petebacondarwin's fix 😓

Screenshot 2025-12-08 at 17 07 46

@dario-piotrowicz
Copy link
Member Author

dario-piotrowicz commented Dec 8, 2025

Oh no.... it looks like something might be wrong with @petebacondarwin's fix 😓

Screenshot 2025-12-08 at 17 07 46

Ah ok that just got fixed 🙂
redwoodjs/create-rwsdk#5

@dario-piotrowicz dario-piotrowicz merged commit 632fb6d into main Dec 8, 2025
30 checks passed
@github-project-automation github-project-automation bot moved this from Approved to Done in workers-sdk Dec 8, 2025
@dario-piotrowicz dario-piotrowicz deleted the dario/c3-quarantined-redwood branch December 8, 2025 17:38
@workers-devprod workers-devprod mentioned this pull request Dec 8, 2025
Merged
vicb added a commit that referenced this pull request Dec 9, 2025
@vicb
Revert "Un-quarantine the RedwoodSDK C3 e2e test and bump create-rwsd…
f130d1d 
…k to 3.1.1 (#11557)"

This reverts commit 632fb6d.
@vicb vicb mentioned this pull request Dec 9, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vicb vicb vicb left review comments

@ascorbic ascorbic ascorbic approved these changes

@jamesopstad jamesopstad Awaiting requested review from jamesopstad

@petebacondarwin petebacondarwin Awaiting requested review from petebacondarwin

Assignees

No one assigned

Labels

skip-v3-pr Skip validation of presence of a v3 backport PR

Projects

workers-sdk
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dario-piotrowicz @jamesopstad @ascorbic @vicb