Skip to content

Set the target JS version to ES2024 #11506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
vicb merged 5 commits into from
Dec 3, 2025
Merged

Set the target JS version to ES2024 #11506

vicb merged 5 commits into from
Dec 3, 2025

Conversation

@vicb
Copy link
Contributor

@vicb vicb commented Dec 3, 2025

v8 supports es2024 features as of 11.9
workerd uses v8 version 14.2 as of 2025-10-17

  • Tests
    • Tests included/updated
    • Tests not necessary because: already covered
  • Public documentation
    • Cloudflare docs PR(s):
    • Documentation not necessary because: not documented
  • Wrangler V3 Backport
    • Wrangler PR:
    • Not necessary because: v3 uses an older workerd version

@vicb vicb requested a review from a team as a code owner December 3, 2025 10:24
@changeset-bot
Copy link

changeset-bot bot commented Dec 3, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: fb8108f

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-project-automation github-project-automation bot moved this to Untriaged in workers-sdk Dec 3, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Dec 3, 2025

Failed to automatically backport this PR's changes to Wrangler v3. Please manually create a PR targeting the v3-maintenance branch with your changes. Thank you for helping us keep Wrangler v3 supported!

Depending on your changes, running git rebase --onto v3-maintenance main vicb/es2024 might be a good starting point.

Notes:

  • your PR branch should be named v3-backport-11506
  • add the skip-v3-pr label to the current PR to stop this workflow from failing

@pkg-pr-new
Copy link

pkg-pr-new bot commented Dec 3, 2025 •
edited
Loading

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@11506

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@11506

miniflare

npm i https://pkg.pr.new/miniflare@11506

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@11506

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@11506

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@11506

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@11506

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@11506

@cloudflare/workers-utils

npm i https://pkg.pr.new/@cloudflare/workers-utils@11506

wrangler

npm i https://pkg.pr.new/wrangler@11506

commit: fb8108f

@vicb vicb added the skip-v3-pr Skip validation of presence of a v3 backport PR label Dec 3, 2025
jamesopstad
jamesopstad approved these changes Dec 3, 2025
View reviewed changes
@github-project-automation github-project-automation bot moved this from Untriaged to Approved in workers-sdk Dec 3, 2025
vicb
vicb commented Dec 3, 2025
View reviewed changes
@vicb vicb merged commit 79d30d4 into main Dec 3, 2025
33 of 34 checks passed
@github-project-automation github-project-automation bot moved this from Approved to Done in workers-sdk Dec 3, 2025
@vicb vicb deleted the vicb/es2024 branch December 3, 2025 19:57
@workers-devprod workers-devprod mentioned this pull request Dec 3, 2025
Merged
@hiendaovinh
Copy link

hiendaovinh commented Dec 5, 2025 •
edited
Loading

Well, technically this causes some regression if we bump the wrangler version manually from 4.51.0 and still keeping the part of overrides: { "esbuild": "0.21.4" } as of default [email protected] with template like this: https://github.com/cloudflare/workflows-starter/blob/main/package.json

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jamesopstad jamesopstad jamesopstad approved these changes

Assignees

No one assigned

Labels

skip-v3-pr Skip validation of presence of a v3 backport PR

Projects

workers-sdk
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vicb @hiendaovinh @jamesopstad