Skip to content

fix(wrangler): prevent SQLite users error from being reported to Sentry #11467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
edmundhung merged 2 commits into from
Dec 10, 2025
Merged

fix(wrangler): prevent SQLite users error from being reported to Sentry #11467

edmundhung merged 2 commits into from
Dec 10, 2025

Conversation

@edmundhung
Copy link
Member

@edmundhung edmundhung commented Nov 28, 2025 •
edited
Loading

Fixes n/a.

@edmundhung edmundhung requested review from a team as code owners November 28, 2025 19:21
@changeset-bot
Copy link

changeset-bot bot commented Nov 28, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: 3f432af

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-project-automation github-project-automation bot moved this to Untriaged in workers-sdk Nov 28, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Nov 28, 2025

Failed to automatically backport this PR's changes to Wrangler v3. Please manually create a PR targeting the v3-maintenance branch with your changes. Thank you for helping us keep Wrangler v3 supported!

Depending on your changes, running git rebase --onto v3-maintenance main edmundhung/fix-sentry-error might be a good starting point.

Notes:

  • your PR branch should be named v3-backport-11467
  • add the skip-v3-pr label to the current PR to stop this workflow from failing

@pkg-pr-new
Copy link

pkg-pr-new bot commented Nov 28, 2025 •
edited
Loading

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@11467

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@11467

miniflare

npm i https://pkg.pr.new/miniflare@11467

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@11467

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@11467

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@11467

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@11467

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@11467

@cloudflare/workers-utils

npm i https://pkg.pr.new/@cloudflare/workers-utils@11467

wrangler

npm i https://pkg.pr.new/wrangler@11467

commit: 3f432af

@edmundhung edmundhung marked this pull request as draft December 1, 2025 11:42
@edmundhung edmundhung force-pushed the edmundhung/fix-sentry-error branch from 9b6a97c to e2af87a Compare December 2, 2025 15:21
@edmundhung edmundhung force-pushed the edmundhung/fix-sentry-error branch from e2af87a to 795100f Compare December 2, 2025 15:21
@edmundhung edmundhung added the skip-v3-pr Skip validation of presence of a v3 backport PR label Dec 2, 2025
@edmundhung edmundhung mentioned this pull request Dec 2, 2025
Draft
@edmundhung edmundhung marked this pull request as ready for review December 2, 2025 17:13
dario-piotrowicz
dario-piotrowicz approved these changes Dec 10, 2025
View reviewed changes
Copy link
Member

@dario-piotrowicz dario-piotrowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! 🤩

@github-project-automation github-project-automation bot moved this from Untriaged to Approved in workers-sdk Dec 10, 2025
lambrospetrou
lambrospetrou reviewed Dec 10, 2025
View reviewed changes
packages/wrangler/src/d1/execute.ts

// Common SQLite Codes
// See https://www.sqlite.org/rescode.html#constraint
const SQLITE_RESULT_CODES = [
Copy link
Contributor

@lambrospetrou lambrospetrou Dec 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SQLITE_AUTH is also a common one thrown when users try to use functions we do not allowlist in workerd.

Copy link
Member Author

@edmundhung edmundhung Dec 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to know. Thanks! Added in 3f432af.

@edmundhung edmundhung merged commit 235d325 into main Dec 10, 2025
39 of 41 checks passed
@edmundhung edmundhung deleted the edmundhung/fix-sentry-error branch December 10, 2025 14:01
@github-project-automation github-project-automation bot moved this from Approved to Done in workers-sdk Dec 10, 2025
@workers-devprod workers-devprod mentioned this pull request Dec 10, 2025
Merged
dario-piotrowicz pushed a commit that referenced this pull request Dec 11, 2025
@edmundhung @dario-piotrowicz
fix(wrangler): prevent SQLite users error from being reported to Sent…
b1f012a 
…ry (#11467)

* fix(wrangler): prevent SQLite users error from being reported to Sentry

* add SQLITE_AUTH to common error codes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lambrospetrou lambrospetrou lambrospetrou approved these changes

@dario-piotrowicz dario-piotrowicz dario-piotrowicz approved these changes

Assignees

No one assigned

Labels

skip-v3-pr Skip validation of presence of a v3 backport PR

Projects

workers-sdk
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@edmundhung @lambrospetrou @dario-piotrowicz