Skip to content

Conversation

@npaun
Copy link
Member

@npaun npaun commented Dec 2, 2025

  • Sometimes our tests are in a tests package. For example, //src/workerd/api/node/tests:assert-test
  • Other times, they're in a tests folder that is not a package. For example, //src/workerd/api:tests/abort-internal-streams-test
  • And in yet another case, they're directly under the package under test. For example //src/workerd/api:actor-kv-test

What is the reason for all these different choices? Personally, I think it's a conspiracy to drive me bonkers, and I'm not going to stand for it. Let's get this under control.

@npaun npaun requested a review from a team December 2, 2025 22:51
@npaun npaun requested review from a team as code owners December 2, 2025 22:51
Copy link
Collaborator

@jasnell jasnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note to self: find another way to drive Nicholas bonkers.

@npaun npaun enabled auto-merge (squash) December 2, 2025 22:55
@npaun npaun merged commit af09aa7 into main Dec 2, 2025
20 checks passed
@npaun npaun deleted the npaun/test-target-consistency branch December 2, 2025 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants