Only print late alarm if time discrepancy is large #5623
Merged
+9
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MellowYarker
requested review from
a-robinson,
jqmmes and
justin-mp
and removed request for
a-robinson
justin-mp
approved these changes
Dec 1, 2025
CodSpeed Performance ReportMerging #5623 will not alter performanceComparing Summary
Footnotes
|
I suspect some of the remaining instances of this log may be due to the alarm manager polling at time T and learning of an alarm that will run at time T + 12 (for example), the application updating the alarm time to T + 1, the alarm manager not being updated (alarm notifier fails + alarm manager polls too infrequently), and then the alarm looking as though it ran late.
MellowYarker
force-pushed
the
milan/STOR-4521-follow-up
branch
from
b006cf5 to
baae0fb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I suspect some of the remaining instances of this log may be due to the alarm manager polling at time T and learning of an alarm that will run at time T + 12 (for example), the application updating the alarm time to T + 1, the alarm manager not being updated (alarm notifier fails + alarm manager polls too infrequently), and then the alarm looking as though it ran late.