implement TLSSocket and connect from node:tls #3594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anonrig
force-pushed
the
yagiz/introduce-tls
branch
2 times, most recently
from
1fb6373 to
e77192f
Compare
|
The generated output of |
|
Nice! |
anonrig
force-pushed
the
yagiz/introduce-tls
branch
8 times, most recently
from
7968547 to
a8848ab
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
anonrig
force-pushed
the
yagiz/introduce-tls
branch
11 times, most recently
from
5c957db to
57490be
Compare
anonrig
force-pushed
the
yagiz/introduce-tls
branch
from
bd7157b to
2018d2d
Compare
jasnell
reviewed
Mar 5, 2025
jasnell
reviewed
Mar 5, 2025
jasnell
reviewed
Mar 5, 2025
jasnell
reviewed
Mar 5, 2025
jasnell
reviewed
Mar 5, 2025
jasnell
reviewed
Mar 5, 2025
jasnell
reviewed
Mar 5, 2025
jasnell
reviewed
Mar 5, 2025
jasnell
reviewed
Mar 5, 2025
jasnell
reviewed
Mar 5, 2025
jasnell
reviewed
Mar 5, 2025
jasnell
reviewed
Mar 5, 2025
jasnell
reviewed
Mar 5, 2025
jasnell
reviewed
Mar 5, 2025
This was referenced Mar 5, 2025
anonrig
force-pushed
the
yagiz/introduce-tls
branch
from
ed45f33 to
27193ac
Compare
anonrig
force-pushed
the
yagiz/introduce-tls
branch
from
cef9fef to
4864e5c
Compare
anonrig
force-pushed
the
yagiz/introduce-tls
branch
from
4864e5c to
57ae248
Compare
jasnell
approved these changes
Mar 6, 2025
|
cc @vicb @petebacondarwin once we have an EW release, we should update unenv to not polyfill these... cc @irvinebroque @mikenomitch it might be good to include this in a changelog entry |
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
node:tlsmodule as well as_tls_wrap. Includes the following methods/classes:TLSSocketconnect()