-
Notifications
You must be signed in to change notification settings - Fork 494
Comparing changes
Open a pull request
base repository: cloudflare/workerd
base: 1ab609f
head repository: cloudflare/workerd
compare: 08ddec5
- 15 commits
- 106 files changed
- 11 contributors
Commits on Dec 1, 2025
-
Only print late alarm if time discrepancy is large
I suspect some of the remaining instances of this log may be due to the alarm manager polling at time T and learning of an alarm that will run at time T + 12 (for example), the application updating the alarm time to T + 1, the alarm manager not being updated (alarm notifier fails + alarm manager polls too infrequently), and then the alarm looking as though it ran late.
Configuration menu - View commit details
-
Copy full SHA for baae0fb - Browse repository at this point
Copy the full SHA baae0fbView commit details -
Configuration menu - View commit details
-
Copy full SHA for b9cc005 - Browse repository at this point
Copy the full SHA b9cc005View commit details
Commits on Dec 2, 2025
-
Merge pull request #5623 from cloudflare/milan/STOR-4521-follow-up
Only print late alarm if time discrepancy is large
Configuration menu - View commit details
-
Copy full SHA for fc6b3d6 - Browse repository at this point
Copy the full SHA fc6b3d6View commit details -
Configuration menu - View commit details
-
Copy full SHA for fa09e00 - Browse repository at this point
Copy the full SHA fa09e00View commit details -
Add Jaeger tracing for waitForBookmark storage API
Add tracing span creation for waitForBookmark at the DurableObjectStorage API layer. Update ActorCacheInterface and ActorSqlite to accept SpanParent parameter for trace context propagation. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for daeafd5 - Browse repository at this point
Copy the full SHA daeafd5View commit details -
Merge pull request #5622 from cloudflare/jmp/waitForBookmark-tracing
Add Jaeger tracing for the waitForBookmark storage API.
Configuration menu - View commit details
-
Copy full SHA for a160b37 - Browse repository at this point
Copy the full SHA a160b37View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5938f01 - Browse repository at this point
Copy the full SHA 5938f01View commit details -
Merge pull request #5574 from cloudflare/ketan/dyworker-noname
Allow omitting name while creating dynamic workers
Configuration menu - View commit details
-
Copy full SHA for b636057 - Browse repository at this point
Copy the full SHA b636057View commit details -
Fix structuredClone() under enhanced_error_serialization.
The comments in ser.c++ suggested that V8 would always treat objects with internal fields as host objects, not calling the `IsHostObject()` callback even when it was enabled. This turns out to be wrong: if HasCustomHostObject() returns true, then IsHostObject() will be called for *all* objects, internal fields or otherwise, and the result respected. Prior to the introduction of `enhanced_error_serialization`, though, `HasCustomHostObject()` would only return true when `treatClassInstancesAsPlainObjects` was false. This inadvertently neutralized the bug, because all objects with internal fields are also "class instances" (i.e. their prototype is something other than `Object.prototype`). So all API objects continued to be treated as host objects. But `enhanced_error_serialization` introduced another way that `HasCustomHostObject()` could return true, even when `treatClassInstancesAsPlainObjects` is also true. Unfortuntaley, in this case, API objects (objects with internal fields) _stopped_ being treated as host objects. Hence, all API objects started being serialized as empty objects, since the default serialization behavior for all objects is to ignore the prototype and just serialize the own properties. The fix is to make sure we check for internal fields in `IsHostObject()`. Ironically, the test for `DOMException` serialization in `js-rpc-test.js` managed to depend on this bug. `enhanced_error_serialization` as implemented doesn't apply to `DOMException`, since it's a custom API object. But the bug caused it to be serialized as a plain object, which ended up causing its own properties to be preserved, as they should be under `enhanced_error_serialization`. However, its _type_ was not preserved, but this was not actually tested, so the test passed by accident. I have removed this test from `js-rpc-test` and recreated it in `rpc-error-test`, where I also adjusted it to verify the type but not the own properties (leaving the latter as a TODO to fix later).
Configuration menu - View commit details
-
Copy full SHA for 153b6e9 - Browse repository at this point
Copy the full SHA 153b6e9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1469fef - Browse repository at this point
Copy the full SHA 1469fefView commit details -
[clang-tidy] Add cppcoreguidelines-prefer-member-initializer and more…
… checks Meant to add cppcoreguidelines-pro-type-member-init since it would have saved me spending hours from tracking down a test failure, but that would be significantly more work.
Configuration menu - View commit details
-
Copy full SHA for ed6674a - Browse repository at this point
Copy the full SHA ed6674aView commit details -
Merge pull request #5627 from cloudflare/kenton/fix-enhanced_error_se…
…rialization-hostobject
Configuration menu - View commit details
-
Copy full SHA for 5656e29 - Browse repository at this point
Copy the full SHA 5656e29View commit details -
Merge pull request #5378 from cloudflare/yagiz/rust-jsg-boilerplate
add initial jsg rust integration
Configuration menu - View commit details
-
Copy full SHA for ff9b8fa - Browse repository at this point
Copy the full SHA ff9b8faView commit details -
Configuration menu - View commit details
-
Copy full SHA for af09aa7 - Browse repository at this point
Copy the full SHA af09aa7View commit details
Commits on Dec 3, 2025
-
Configuration menu - View commit details
-
Copy full SHA for 08ddec5 - Browse repository at this point
Copy the full SHA 08ddec5View commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff 1ab609f...08ddec5