Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: cloudflare/workerd
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 1ab609f
Choose a base ref
...
head repository: cloudflare/workerd
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 08ddec5
Choose a head ref
  • 15 commits
  • 106 files changed
  • 11 contributors

Commits on Dec 1, 2025

  1. Only print late alarm if time discrepancy is large

    I suspect some of the remaining instances of this log may be due to the
    alarm manager polling at time T and learning of an alarm that will run
    at time T + 12 (for example), the application updating the alarm time to
    T + 1, the alarm manager not being updated (alarm notifier fails + alarm
    manager polls too infrequently), and then the alarm looking as though it
    ran late.
    MellowYarker committed Dec 1, 2025
    Configuration menu
    Copy the full SHA
    baae0fb View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    b9cc005 View commit details
    Browse the repository at this point in the history

Commits on Dec 2, 2025

  1. Merge pull request #5623 from cloudflare/milan/STOR-4521-follow-up

    Only print late alarm if time discrepancy is large
    MellowYarker authored Dec 2, 2025
    Configuration menu
    Copy the full SHA
    fc6b3d6 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    fa09e00 View commit details
    Browse the repository at this point in the history
  3. Add Jaeger tracing for waitForBookmark storage API

    Add tracing span creation for waitForBookmark at the DurableObjectStorage
    API layer. Update ActorCacheInterface and ActorSqlite to accept SpanParent
    parameter for trace context propagation.
    
    🤖 Generated with [Claude Code](https://claude.com/claude-code)
    
    Co-Authored-By: Claude <[email protected]>
    justin-mp and claude committed Dec 2, 2025
    Configuration menu
    Copy the full SHA
    daeafd5 View commit details
    Browse the repository at this point in the history
  4. Merge pull request #5622 from cloudflare/jmp/waitForBookmark-tracing

    Add Jaeger tracing for the waitForBookmark storage API.
    justin-mp authored Dec 2, 2025
    Configuration menu
    Copy the full SHA
    a160b37 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    5938f01 View commit details
    Browse the repository at this point in the history
  6. Merge pull request #5574 from cloudflare/ketan/dyworker-noname

    Allow omitting name while creating dynamic workers
    ketanhwr authored Dec 2, 2025
    Configuration menu
    Copy the full SHA
    b636057 View commit details
    Browse the repository at this point in the history
  7. Fix structuredClone() under enhanced_error_serialization.

    The comments in ser.c++ suggested that V8 would always treat objects with internal fields as host objects, not calling the `IsHostObject()` callback even when it was enabled. This turns out to be wrong: if HasCustomHostObject() returns true, then IsHostObject() will be called for *all* objects, internal fields or otherwise, and the result respected.
    
    Prior to the introduction of `enhanced_error_serialization`, though, `HasCustomHostObject()` would only return true when `treatClassInstancesAsPlainObjects` was false. This inadvertently neutralized the bug, because all objects with internal fields are also "class instances" (i.e. their prototype is something other than `Object.prototype`). So all API objects continued to be treated as host objects.
    
    But `enhanced_error_serialization` introduced another way that `HasCustomHostObject()` could return true, even when `treatClassInstancesAsPlainObjects` is also true. Unfortuntaley, in this case, API objects (objects with internal fields) _stopped_ being treated as host objects. Hence, all API objects started being serialized as empty objects, since the default serialization behavior for all objects is to ignore the prototype and just serialize the own properties.
    
    The fix is to make sure we check for internal fields in `IsHostObject()`.
    
    Ironically, the test for `DOMException` serialization in `js-rpc-test.js` managed to depend on this bug. `enhanced_error_serialization` as implemented doesn't apply to `DOMException`, since it's a custom API object. But the bug caused it to be serialized as a plain object, which ended up causing its own properties to be preserved, as they should be under `enhanced_error_serialization`. However, its _type_ was not preserved, but this was not actually tested, so the test passed by accident. I have removed this test from `js-rpc-test` and recreated it in `rpc-error-test`, where I also adjusted it to verify the type but not the own properties (leaving the latter as a TODO to fix later).
    kentonv committed Dec 2, 2025
    Configuration menu
    Copy the full SHA
    153b6e9 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    1469fef View commit details
    Browse the repository at this point in the history
  9. [clang-tidy] Add cppcoreguidelines-prefer-member-initializer and more…

    … checks
    
    Meant to add cppcoreguidelines-pro-type-member-init since it would have saved me
    spending hours from tracking down a test failure, but that would be
    significantly more work.
    fhanau committed Dec 2, 2025
    Configuration menu
    Copy the full SHA
    ed6674a View commit details
    Browse the repository at this point in the history
  10. Merge pull request #5627 from cloudflare/kenton/fix-enhanced_error_se…

    …rialization-hostobject
    jasnell authored Dec 2, 2025
    Configuration menu
    Copy the full SHA
    5656e29 View commit details
    Browse the repository at this point in the history
  11. Merge pull request #5378 from cloudflare/yagiz/rust-jsg-boilerplate

    add initial jsg rust integration
    mikea authored Dec 2, 2025
    Configuration menu
    Copy the full SHA
    ff9b8fa View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    af09aa7 View commit details
    Browse the repository at this point in the history

Commits on Dec 3, 2025

  1. Release 2025-12-03

    workers-devprod committed Dec 3, 2025
    Configuration menu
    Copy the full SHA
    08ddec5 View commit details
    Browse the repository at this point in the history
Loading