Skip to content
This repository was archived by the owner on Jul 22, 2020. It is now read-only.

Comments

Remove all alert groups in Grid.Clear()#91

Merged
prymitive merged 1 commit intomasterfrom
fix-grid-clear
May 6, 2017
Merged

Remove all alert groups in Grid.Clear()#91
prymitive merged 1 commit intomasterfrom
fix-grid-clear

Conversation

@prymitive
Copy link
Contributor

Clear was only hiding elements so div objects were still present, ensure they are removed from the DOM

Steps to reproduce:

  1. Start unsee backend
  2. Navigate browser to it
  3. Stop unsee backend
  4. Grid is clear and error message is displayed
  5. Inspect live page HTML with dev tools - #alerts will still have all alert group elements, just hidden

After this commit all alert group elements under #alerts will be gone (except #grid-sizer which is needed by masonry).

Clear was only hiding elements so div objects were still present, ensure they are removed from the DOM
@prymitive prymitive added the bug label May 5, 2017
@prymitive prymitive merged commit 4ade516 into master May 6, 2017
@prymitive prymitive deleted the fix-grid-clear branch May 6, 2017 07:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants