Skip to content
This repository was archived by the owner on Jul 22, 2020. It is now read-only.

Rewrite js classes using prototypes#88

Merged
prymitive merged 1 commit intomasterfrom
legacy-classes
May 3, 2017
Merged

Rewrite js classes using prototypes#88
prymitive merged 1 commit intomasterfrom
legacy-classes

Conversation

@prymitive
Copy link
Contributor

This removes the requirement on ES6 support in the browser, which will allow to use unsee on older browsers

This removes the requirement on ES6 support in the browser, which will allow to use unsee on older browsers
@prymitive prymitive requested review from Tenzer and jamesog May 2, 2017 12:52
Copy link
Contributor

@jamesog jamesog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

¯\(ツ)

Copy link

@Tenzer Tenzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be good to establish somewhere what range of browsers we aim to support for any contributors. Usually terms like "the current version plus 1/2 older" works.

@prymitive
Copy link
Contributor Author

Without a CI job that would test this it's going to be very hypothetical

@prymitive prymitive merged commit e827b73 into master May 3, 2017
@prymitive prymitive deleted the legacy-classes branch May 3, 2017 09:11
@Tenzer
Copy link

Tenzer commented May 3, 2017

It would, but it at least still documents what the intended range of browser support is instead of leaving people guessing. It also means that people who experience problems on an older browser can report problems if it's inside the range of those we intent to support, rather than just assume it doesn't work due to their old browser being unsupported.

@prymitive
Copy link
Contributor Author

I don't know what that range currently is or should be. Even if I pick some random browser I have no way of knowing if any new change breaks any of those browsers.
Should we support all possible browsers? Why not.
Should we avoid making code complex when trying to support an ancient browser with minimal user base? Probably.
I'd rather not give an answer to a question I don't know how to answer and if someone raises a bug look into it and see if it can be fixed.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants