This repository was archived by the owner on Jul 22, 2020. It is now read-only.
Merged
Conversation
Those will check if we pass correct Host headers and Basic Auth info
This was referenced Apr 18, 2018
Contributor
|
Thx a lot for pushing this @prymitive! (i did a similiar fix on my fork but was too slow with providing proper tests to create a new PR :)) |
terinjokes
approved these changes
Apr 18, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added more tests as it was reported that user:pass is not set for proxied requests, tests confirmed that it's not set (they started failing) so fixed the code.