Remove Host header attribute from proxied request#252
Remove Host header attribute from proxied request#252prymitive merged 5 commits intocloudflare:masterfrom
Conversation
|
Before I merge this I need to check if we should delete it or overwrite it, but seems like you found the root cause. I'll do that a bit later and once I'm confident that the right solution I'll release 0.9.2. |
So I do think that we should drop |
Just to be sure - @svenmueller can you verify if it's still working for you with those 2 lines? |
|
I just did build a new Docker image with the changes in this PR but i still see that the wrong hostname is used when doing proxied request (access log in alertmanager shows wrong hostname). Not sure if i miss something. Needs more investigation. |
|
if i dump the whole request, it looks like this. The host header is still set. |
|
Ok, overwriting the host value seems to work. I can see that the correct hostname is logged in the logs of the target Alertmanager. Only problem is that the Basic Auth information is not passed to the proxied target, which results in a |
|
Ensuring we pass the correct Host header is needed, but I need to setup proper test coverage for this. I'll follow up this PR with more changes. |
|
I've added more tests and confirmed that basic auth is missing for proxied requests - see #256 |
Explicitly set hostame for proxied requests
Solves issue #250