This repository was archived by the owner on Jul 22, 2020. It is now read-only.
Use decoded URI path partial for file paths#225
Merged
Conversation
For absolute paths we correctly return full decoded path, but for relative paths we can't simply strip file:// prefix as it might leave query args in place. Build absolute path by joining working dir + hostname part + path part. Add an extra test case for coverage.
prymitive
force-pushed
the
file-uri-fix
branch
from
0a61d6c to
782b633
Compare
bobrik
approved these changes
Jan 27, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
URI passed to the file:// schema handler might contain query args (?limit=10), when we use a relative path we correctly return u.Path, but for absolute paths full uri with stripped schema part was used. Absolute path should be assembled only current dir and path u.Path
This was only affecting Alertmanager
0.4.xthat uses pagination and requires?limit=Nquery args:with this PR reading works correctly: