Skip to content
This repository was archived by the owner on Jul 22, 2020. It is now read-only.

Comments

Use bakelite to cross-compile binaries on Travis#212

Merged
prymitive merged 1 commit intomasterfrom
bakelite
Jan 29, 2018
Merged

Use bakelite to cross-compile binaries on Travis#212
prymitive merged 1 commit intomasterfrom
bakelite

Conversation

@prymitive
Copy link
Contributor

Solves #167 while keeping all code in .travis.yml, there's only one new make target (show-version) but it's just a helper so we don't need to duplicate the code for getting version string.

@prymitive
Copy link
Contributor Author

Downside is that build times are more than doubled (~8m -> ~20m), but there's not really any way around it with cross-compiling, more work == more time needed, and this already found small issues when building for 32 bits. This new job is the last one, so most issues should fail a job early.

.travis.yml Outdated
# compile assets via webpack and build those into bindata_assetfs.go file
- make bindata_assetfs.go
# and now compile using bakelite for all target archs
- go get -u github.com/terinjokes/bakelite
Copy link

@terinjokes terinjokes Jan 13, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although I don't expect to have breaking changes, you may prefer to fetch a release instead.

Copy link
Contributor Author

@prymitive prymitive Jan 14, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last time I checked it was not possible with go get and github, only packages hosted on gopkg.in support getting a specific release, is that no longer true?

Copy link

@terinjokes terinjokes Jan 14, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can use dep's required. You can also fetch the release tarball from GitHub, extract it, and run it from there.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

release tarball it is

@prymitive prymitive force-pushed the bakelite branch 2 times, most recently from 7231955 to 7a61e75 Compare January 14, 2018 03:01
@prymitive prymitive added this to the v0.9 milestone Jan 21, 2018
@prymitive prymitive force-pushed the bakelite branch 2 times, most recently from 9b6c122 to a4f4007 Compare January 25, 2018 02:57
@prymitive prymitive merged commit eabb4a2 into master Jan 29, 2018
@prymitive prymitive deleted the bakelite branch January 29, 2018 05:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants