This repository was archived by the owner on Jul 22, 2020. It is now read-only.
Merged
Conversation
bobrik
approved these changes
Dec 5, 2017
Reduce number of targets used internally for building and use less confusing names. Add webpack target that will be needed for node only docker build stage.
Go docker image uses old nodejs, split build into 2 stages so we can have better control over used nodejs and Go images
…ravis runs npm install and then we run it too
prymitive
force-pushed
the
3-stage-build
branch
from
8002536 to
e11dde8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've noticed that the docker images we use are running old nodejs version - https://travis-ci.org/cloudflare/unsee/jobs/311602111#L529
As a result dependencies aren't correctly enforced when building docker image - https://travis-ci.org/cloudflare/unsee/jobs/311602111#L1573
Using separate nodejs and Go images seems like the best solution. Makefile cleanup was needed to add this. With this PR all nodejs deps are installed in the correct version - https://travis-ci.org/cloudflare/unsee/jobs/311697485#L558